Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSome chart injections are happening incorrectly #1039
Labels
Comments
|
I don't know who works on ocular? @jckr ? |
|
thanks for raising. will take a look.
…On Tue, Nov 13, 2018 at 2:51 PM Andrew McNutt ***@***.***> wrote:
I don't know who works on ocular? @jckr <https://github.com/jckr> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1039 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJRujq8ZifISKTjywtjSjSDKn4CPR-aPks5uu0zkgaJpZM4YcrWw>
.
|
|
Ok. This happens when there are 2 such inject statements in the same page in a specific form.
Now if we change the regex a little bit....
I have to change ocular though to make this work. |
|
Oh no!!! That's a classic regex error. I think that particular one might be on me, oh no! Let me know if there's anything I can do to help |
|
Any update on this? |
|
@jckr bump on this? |
mcnuttandrew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In an apparently random collection of docs pages, the injection script is not correctly inserting the charts where they should go. For instance at https://uber.github.io/react-vis/documentation/api-reference/axes there should be two charts injected but none appear! I took a glance at the code and I don't really know where is going on. Is it possible the ocular bump that happened recently borked the injection?