Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upText artifacts left in "hello" demo #270
Comments
This comment has been minimized.
This comment has been minimized.
|
Hi LiamMW I just noticed this the other day too, when testing on a Windows VM. This looks like a Python Unicode issue. We'll have to do some research to find the right solution here, but it would be great if someone with more Windows experience could chip in. |
This comment has been minimized.
This comment has been minimized.
|
I have seen those weird symbols before. I think its because its often the case in Windows that the default encoding is latin-1 instead of UTF-8. |
This comment has been minimized.
This comment has been minimized.
|
Not sure if we want to include new dependencies, but I see there are a few issues relating to encoding. A bit of a brute force approach to solving those issues that has worked well in the past, if you have a broad user base is called; ftfy (fix text for you). Perhaps this could be handy for streamlit? |
This comment has been minimized.
This comment has been minimized.
|
Oh, that's an interesting Python module. As you say, we should be judicious about adding dependencies, so let's see if we can solve this without that. But that's a good candidate in case we have no recourse Can someone try this on Windows? (As luck would have it, my Windows machine just broke...)
Do any of these print correctly? (If no response after I'm done triaging all pending issues, I'll download and run a Windows VM to try this out myself) |
This comment has been minimized.
This comment has been minimized.
|
I'll give it a test later today and let you know. |
This comment has been minimized.
This comment has been minimized.
|
Hi @tvst , I use windows machine and is getting similar output on running the demo. These are the outputs I got
Script execution error(popup window) - 'charmap' codec can't decode byte 0x8d in position 65: character maps to
Using escaped unicode:
Script execution error(popup window) - 'charmap' codec can't decode byte 0x8d in position 95: character maps to
Using escaped unicode and explicit unicode literal: |
Summary
Some form of text corruption artefact on the the "hello" demo.
Steps to reproduce
What are the steps we should take to reproduce the bug:
Expected behavior:
Non corrupted text
Actual behavior:
In the "choose a demo" drop down the default page is called 'â€"' and the title is 'Welcome to Streamlit! 👋'
Is this a regression?
no
Debug info
$ streamlit version) = Streamlit, version 0.47.3$ python --version) = Python 3.7.3