Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 611: 'The one million limit' #1249

Merged
merged 7 commits into from Dec 6, 2019
Merged

PEP 611: 'The one million limit' #1249

merged 7 commits into from Dec 6, 2019

Conversation

@markshannon
Copy link
Contributor

@markshannon markshannon commented Dec 5, 2019

Draft version of PEP 611, "The one million limit".


The one million limit is mostly a limit on human generated code, not runtime sizes.

One million lines in a single module is a rediculous concentration of code;

This comment has been minimized.

@JelleZijlstra

JelleZijlstra Dec 5, 2019
Contributor

ridiculous

This comment has been minimized.

@markshannon

markshannon Dec 6, 2019
Author Contributor

thanks

@Rosuav
Copy link
Contributor

@Rosuav Rosuav commented Dec 5, 2019

Folks, can we refrain from using this PR as a vehicle for discussions about the contents of the PEP please? Minor typos perhaps ("ridiculous"), but let's just get the PEP into the repo first, and then have the discussion on python-ideas.

@markshannon, Travis is showing a problem with the markup. Once that's sorted, this can be merged.


The one million limit is mostly a limit on human generated code, not runtime sizes.

One million lines in a single module is a rediculous concentration of code;

This comment has been minimized.

@brettcannon

brettcannon Dec 5, 2019
Member

Suggested change
One million lines in a single module is a rediculous concentration of code;
One million lines in a single module is a ridiculous concentration of code;

This comment has been minimized.

@markshannon

markshannon Dec 6, 2019
Author Contributor

thanks

@RMJ10
Copy link

@RMJ10 RMJ10 commented Dec 5, 2019

Apologies all, I confused myself into believing discussion had been redirected here. This is what I get for following the link to the PR while updating a wiki for another project and writing JIRA tickets for yet another. Clearly I need a lower limit on Things Rhodri Is Supposed To Do Simultaneously :-)

@Rosuav
Copy link
Contributor

@Rosuav Rosuav commented Dec 6, 2019

Clearly that number should be capped at one million :-)

markshannon added 2 commits Dec 6, 2019
… enforcement and about other implementations.
@Rosuav Rosuav merged commit c2171bc into python:master Dec 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Rosuav
Copy link
Contributor

@Rosuav Rosuav commented Dec 6, 2019

Merged. Should be live soon. Let the bikeshedding commence!!

Oh wait, it already has. Have fun! :)

@python python deleted a comment from markshannon Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants