Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link in colorsys docs to be https #14062

Merged
merged 1 commit into from Jun 15, 2019
+1 −1

Conversation

Reviewers

@tirkarthi tirkarthi

@csabella csabella

Assignees

@miss-islington miss-islington

Labels
🤖 automerge CLA signed skip issue skip news type-documentation
Projects
None yet
Milestone
No milestone
6 participants
@alex @miss-islington @bedevere-bot @tirkarthi @csabella @the-knights-who-say-ni
@alex
Copy link
Member

commented Jun 13, 2019 •
edited

No description provided.

@alex
Update link in colorsys docs to be https
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f4daaf0

@alex alex added needs backport to 2.7 type-documentation skip issue skip news labels Jun 13, 2019

@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 13, 2019

@bedevere-bot bedevere-bot added the awaiting core review label Jun 13, 2019

@tirkarthi

tirkarthi approved these changes Jun 14, 2019
View changes

Copy link
Contributor

left a comment

LGTM. Thanks.
@csabella

csabella approved these changes Jun 15, 2019
View changes

Copy link
Contributor

left a comment

LGTM, thanks!

@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 15, 2019

@alex alex added the 🤖 automerge label Jun 15, 2019

@miss-islington miss-islington merged commit 6ef4d32 into master Jun 15, 2019
5 checks passed

5 checks passed

Azure Pipelines PR #20190613.56 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

commented Jun 15, 2019

Thanks @alex for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the awaiting merge label Jun 15, 2019

@miss-islington

This comment has been minimized.

Sign in to view
Copy link

commented Jun 15, 2019

Sorry, @alex, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6ef4d323bdb0f910d6e5e4d81a654253d4d1bcd5 2.7

@miss-islington miss-islington self-assigned this Jun 15, 2019

@alex alex deleted the alex-patch-1 branch Jun 15, 2019

alex added a commit that referenced this pull request Jun 15, 2019

@alex
[2.7] Update link in colorsys docs to be https (GH-14062)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
474ec0a

@bedevere-bot bedevere-bot removed the needs backport to 2.7 label Jun 15, 2019

@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 15, 2019

GH-14110 is a backport of this pull request to the 2.7 branch.

miss-islington added a commit that referenced this pull request Jun 18, 2019

@alex @miss-islington
[2.7] Update link in colorsys docs to be https (GH-14062) (GH-14110)
Loading status checks…
eb8b559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.