Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Guide for app notarization #18609

Open
MarshallOfSound opened this issue Jun 3, 2019 · 7 comments
Open

Create a Guide for app notarization #18609

MarshallOfSound opened this issue Jun 3, 2019 · 7 comments
Assignees

Comments

@MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Jun 3, 2019

As of macOS Catalina Apple will be requiring that apps are notarized, we all saw this day coming and are slightly prepared. The tooling exists, we just need to document how everyone can use it.

Refs: https://github.com/electron-userland/electron-notarize
Refs: https://github.com/electron-userland/electron-packager/blob/master/docs/api.md#osxnotarize

@Kilian

This comment has been minimized.

Copy link
Member

@Kilian Kilian commented Jun 4, 2019

Ref for electron-builder/general "other stuff Apple wants you to do when notarizing": https://kilianvalkhof.com/2019/electron/notarizing-your-electron-application/

I'd be happy to get an in-detail guide started (or if anyone feels like it, they're welcome to plagiarize use any part of the article.)

@arvidkahl

This comment has been minimized.

Copy link

@arvidkahl arvidkahl commented Jun 5, 2019

Thank you Kilian for the walkthrough. This is one of those rare blogposts that are immediately comprehensive, instructive and (almost) error-free (there is a } to many in the afterSign script you provide IIRC).

An in-depth guide would certainly be helpful, but the post is already sufficient to implement this in 15 minutes. And then, of course, wait another 15 minutes for the Apple API to grace you with a working ticket.

@Kilian

This comment has been minimized.

Copy link
Member

@Kilian Kilian commented Jun 5, 2019

(there is a } to many in the afterSign script you provide IIRC).

Cheers, fixed!

@lukeapage

This comment has been minimized.

Copy link
Contributor

@lukeapage lukeapage commented Jun 18, 2019

We're trying to reproduce getting a security warning with a signed app - either in mojave or the catalina beta - and even though the app is signed after 1st June and not notarized, we are not getting blocked or seeing additional warnings other than the (you downloaded this from the internet). we are using a dmg.

Has anyone seen this affect an electron app or have more info about how to reproduce the blocking?

@Kilian

This comment has been minimized.

Copy link
Member

@Kilian Kilian commented Jun 18, 2019

@lukeapage

This comment has been minimized.

Copy link
Contributor

@lukeapage lukeapage commented Jun 18, 2019

We eventually reproduced by allowing the beta to update itself to the latest beta. Our developer account fits that criteria and our app is blocked. Thanks for the suggestion.

@Mizzick

This comment has been minimized.

Copy link

@Mizzick Mizzick commented Jul 19, 2019

With two last Catalina betas we started to have some notarization or signing problems here
AdguardTeam/AdGuardForSafari#172
and as it mentioned in the issue, there are same problems even with Whatsapp.

So I guess, the notarization requirement is in full effect already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.