Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix SCRAM implementation to adhere spec #60
Merged
Conversation
tailhook
added a commit
to edgedb/edgedb
that referenced
this pull request
Dec 27, 2019
The edgedb-python that requires this is: edgedb/edgedb-python#60
By specification `nonce` is not base64 encoded string. Quoting the spec: > o r: This attribute specifies a sequence of random printable ASCII > characters excluding ',' (which forms the nonce used as input to > the hash function). No quoting is applied to this string. I mean current edgedb doesn't accept anything other than valid base64-encoded string including padding, which is wrong. (The generation of nonce using base64 as well as client implementation are fine).
sthagen
added a commit
to sthagen/edgedb-python
that referenced
this pull request
Dec 29, 2019
Merged
1st1
added a commit
to edgedb/edgedb
that referenced
this pull request
Dec 30, 2019
The edgedb-python that requires this is: edgedb/edgedb-python#60
elprans
added a commit
that referenced
this pull request
Dec 30, 2019
elprans
added a commit
that referenced
this pull request
Dec 30, 2019
elprans
added a commit
that referenced
this pull request
Dec 30, 2019
elprans
added a commit
that referenced
this pull request
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tailhook commentedDec 27, 2019
•
edited
By specification
nonceis not base64 encoded string. Quoting thespec:
I mean current edgedb doesn't accept anything other than valid
base64-encoded string including padding, which is wrong. (The generation
of nonce using base64 as well as client implementation are fine).
Unfortunately this requires a tiny patch in the edgedb itself (so tests are broken now).