Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option "Close Tabs to the Right" to right-click context menu of tabs #822

Open
mlangkabel opened this issue Dec 3, 2019 · 7 comments
Open

Comments

@mlangkabel
Copy link
Contributor

@mlangkabel mlangkabel commented Dec 3, 2019

Implementation suggestion:

  • override void contextMenuEvent(QContextMenuEvent* event) in QtTabsBar
  • Instantiate QtContextMenu and add this action to it (see QtGraphicsView for example)
  • when action is triggered emit a signal, e.g. closeTabsToRight(Id tabId).
  • catch that signal in QtTabsView and handle logic there
@kalashshah11

This comment has been minimized.

Copy link

@kalashshah11 kalashshah11 commented Dec 7, 2019

I am interested to work on the project for some time. Can you provide me with details on how can I start with? I am a 2nd-year undergrad.

@egraether

This comment has been minimized.

Copy link
Contributor

@egraether egraether commented Dec 9, 2019

@kalashshah11 I updated the description above to give some pointers.

@kalashshah11

This comment has been minimized.

Copy link

@kalashshah11 kalashshah11 commented Dec 10, 2019

@egraether Thanks for updating.Would complete it as soon as possible.

@kalashshah11

This comment has been minimized.

Copy link

@kalashshah11 kalashshah11 commented Dec 10, 2019

@egraether I am getting an error of CMake Error at "D:/......." Could NOT find Boost (missing: Boost_INCLUDE_DIR system program_options filesystem date_time) (Required is at least version "1.67")
and am not being able to load the project

@mlangkabel

This comment has been minimized.

Copy link
Contributor Author

@mlangkabel mlangkabel commented Dec 10, 2019

Please read the Building the Bare Minimum section of our readme and install the required software.

@kalashshah11

This comment has been minimized.

Copy link

@kalashshah11 kalashshah11 commented Dec 11, 2019

After following the ReadME file, still, I am getting the same errors

@mlangkabel

This comment has been minimized.

Copy link
Contributor Author

@mlangkabel mlangkabel commented Dec 11, 2019

Are you working on Windows? Maybe you need to define a CMake Cache Entry called BOOST_ROOT (hm, maybe the casing was different, but give it a try) pointing to the directory that contains the "boost" folder, e.g., C:\Program Files\boost\boost_1_68_0. If that doesn't help, just google for CMake find boost and see if anything that comes up helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.