Skip to content

/ vscode-python Public

forked from DonJayamanne/pythonVSCode
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "python.workspaceSymbols.enabled" to default to false #9046

Closed
gwk opened this issue Dec 12, 2019 · 2 comments
Closed

Change "python.workspaceSymbols.enabled" to default to false #9046

gwk opened this issue Dec 12, 2019 · 2 comments
Assignees
@kimadeline
Labels
area-intellisense bug P0 reason-preexisting
Milestone
2019 December Spr...

Comments

@gwk
Copy link

@gwk gwk commented Dec 12, 2019

Issue Type: Bug

Note: originally filed as microsoft/vscode#86766 and sent here.

I have a testing framework that creates symlinks in subdirectories of the _build directory. Recently, VSCode Insiders has started spontaneously opening the "OUTPUT" tab of the console tray, and spewing tons of warnings from "ctag". Here are the first few lines:

> conda --version
> pyenv root
> python3.7 -c "import sys;print(sys.executable)"
> python3.6 -c "import sys;print(sys.executable)"
> python3 -c "import sys;print(sys.executable)"
> python2 -c "import sys;print(sys.executable)"
> python -c "import sys;print(sys.executable)"
> /usr/local/gloss/bin/python3 -c "import sys;print(sys.executable)"
> conda info --json
> conda info --json
> conda info --json
> conda info --json
> conda --version
> conda --version
> conda --version
> /usr/local/gloss/bin/python3 -c "import sys;print(sys.executable)"
> /usr/local/gloss/bin/python3 -c "import sys;print(sys.executable)"
> /usr/local/gloss/bin/python3 -c "import sys;print(sys.executable)"
> /usr/local/gloss/bin/python3 -c "import sys;print(sys.executable)"
> /usr/local/gloss/bin/python3 -c "import sys;print(sys.executable)"
> /usr/local/gloss/bin/python3 -c "import sys;print(sys.executable)"
> /usr/local/gloss/bin/python3 -c "import sys;print(sys.executable)"
> /usr/local/gloss/bin/python3 -c "import sys;print(sys.executable)"
Starting Jedi Python language engine.
----------Generating Tags----------
ctags --options=/Users/gwk/.vscode-insiders/extensions/ms-python.python-2019.12.53195-dev/resources/ctagOptions --languages=Python --exclude=**/site-packages/** -o /Users/gwk/work/muck/.vscode/tags .
> ctags --options=/Users/gwk/.vscode-insiders/extensions/ms-python.python-2019.12.53195-dev/resources/ctagOptions --languages=Python --exclude=**/site-packages/** -o ~/work/muck/.vscode/tags .
cwd: ~/work/muck
> /usr/local/gloss/bin/python3 -c "import sys;print(sys.executable)"
> /usr/local/gloss/bin/python3 -c "import sys;print(sys.executable)"
> /usr/local/gloss/bin/python3 -c "import sys;print(sys.executable)"
> /usr/local/gloss/bin/python3 -c "import sys;print(sys.executable)"
ctags: Warning: cannot open source file "pithy/_build/test/svg/svg.py" : No such file or directory
...

Followed by many more warnings.

Additionally, I now see a .vscode/tags file getting generated in all of my projects, which I need to exclude in gitignore.

I am guessing this is a new feature being rolled out, and this is what I get for using Insiders. But, some honest feedback:

  • The spontaneous switch to focus on the output pane is very disruptive.
  • The new tags file is annoying (must be gitignored).
  • When I search for text in my project, I now get search results from the generated "tags" file, which seems like something that nobody would ever want.
  • Adding my _build directory to "files.exclude" setting does not fix the ctags warnings.
  • It looks like the call to ctags takes an --exclude flag; it should probably at least respect files.exclude setting.

I have managed to work around the problem by the setting python.workspaceSymbols.enabled: false. I still think it represents a serious usability issue however. VSCode was essentially unusable until I switched that off, because the output pane was randomly stealing focus from the text editor every few minutes. Additionally, the presence of the large tags file inside the project directory seems like a bad design.

Thank you, -George

VS Code version: Code - Insiders 1.41.0-insider (87c2e0be5d7359ce110c4c9ec9f6df71be996f8a, 2019-12-06T21:34:49.305Z)
OS version: Darwin x64 19.2.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz (8 x 3100)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 6, 5, 4
Memory (System) 16.00GB (2.31GB free)
Process Argv .
Screen Reader no
VM 0%
Extensions (24)
Extension Author (truncated) Version
npm-intellisense chr 1.3.0
crafts gwk 1.0.0
vscode-eslint dba 1.9.1
vscode-dash dee 2.3.0
gitlens eam 10.2.0
vscode-npm-script eg2 0.3.9
macros ged 1.2.1
gloss gwk 1.0.0
vscode-settings-cycler hoo 1.0.1
vsc-python-indent Kev 1.8.1
legs gwk 1.0.0
vscode-docker ms- 0.9.0
python ms- 2019.12.53195-dev
cpptools ms- 0.26.2
debugger-for-chrome msj 4.12.3
erlang pgo 0.5.2
ploy gwk 1.0.0
vscode-yaml red 0.6.1
vscode-hexdump sle 1.7.2
cython tcw 0.1.0
pdf tom 0.5.1
vscode-lldb vad 1.4.3
change-case wma 1.0.0
writeup gwk 1.0.0
@gwk gwk mentioned this issue Dec 12, 2019
Closed
@brettcannon brettcannon changed the title "Generating Tags" process is noisy and disruptive. Change "python.workspaceSymbols.enabled" to default to false Dec 12, 2019
@brettcannon
Copy link
Member

@brettcannon brettcannon commented Dec 12, 2019

@gwk thanks for letting us know! We just fixed an issue with building symbols and it was overlooked that the setting to build symbols was on by default. We will be changing the default to be off shortly.

@ghost ghost removed the classify label Dec 12, 2019
@kimadeline kimadeline mentioned this issue Dec 12, 2019
Merged
10 tasks
@kimadeline kimadeline added this to the 2019 December Sprint 1 milestone Dec 12, 2019
@ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Dec 19, 2019

Using the insiders build I was able to verify that the default is false. (I checked that it defaulted to "true" with the last release.)

@ghost ghost removed the needs PR label Dec 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kimadeline kimadeline

Labels
area-intellisense bug P0 reason-preexisting
Projects
None yet
Milestone
2019 December Sprint 1
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@brettcannon @gwk @ericsnowcurrently @kimadeline