Skip to content

/ pre-commit

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make verbose output less special #1249

Merged
merged 1 commit into from Dec 24, 2019
Merged

Make verbose output less special #1249

merged 1 commit into from Dec 24, 2019

Conversation

@asottile
Copy link
Member

@asottile asottile commented Dec 23, 2019

Other side-effects of this change:

  • the return code of an individual hook is shown
  • the maximum return code is the one which is used (this should make it easier to debug for instance this issue)

old verbose

(hard to tell here, but the old verbose changes the width of what gets rendered)

Capture10

new verbose

Capture8

new non-verbose

Capture9
@asottile asottile force-pushed the simpler_verbose branch from 2abe325 to b2b8b2c Dec 23, 2019
@asottile
Make verbose output less special
Loading status checks…
01a628d
@asottile asottile force-pushed the simpler_verbose branch from b2b8b2c to 01a628d Dec 23, 2019
@asottile asottile merged commit 83f0802 into master Dec 24, 2019
1 check passed
1 check passed
pre-commit.pre-commit #20191223.5 succeeded
Details
@asottile asottile deleted the simpler_verbose branch Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@asottile
You can’t perform that action at this time.