Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use echo instead of python in parse_shebang_test #1236

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@asottile
Copy link
Member

@asottile asottile commented Dec 6, 2019

See #1235

This makes the test succeed better when not in a virtualenv (where both python and python3 executables will exist)

@asottile
Copy link
Member Author

@asottile asottile commented Dec 6, 2019

oh right that's not going to work well on windows

@asottile asottile closed this Dec 6, 2019
@asottile asottile deleted the future_proof_parse_shebang_test branch Dec 6, 2019
@asottile asottile restored the future_proof_parse_shebang_test branch Dec 6, 2019
@asottile asottile reopened this Dec 6, 2019
@asottile asottile force-pushed the future_proof_parse_shebang_test branch from 2c43b34 to 9fada61 Dec 6, 2019
@asottile asottile changed the title Use python3 instead of python in parse_shebang_test Use echo instead of python in parse_shebang_test Dec 6, 2019
@asottile asottile merged commit fe10811 into master Dec 6, 2019
1 check passed
1 check passed
pre-commit.pre-commit #20191206.6 succeeded
Details
@asottile asottile deleted the future_proof_parse_shebang_test branch Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.