Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloaded + Unread badge are inaccurate #2172

Open
kevinlin12345 opened this issue Aug 9, 2019 · 1 comment
Open

Downloaded + Unread badge are inaccurate #2172

kevinlin12345 opened this issue Aug 9, 2019 · 1 comment

Comments

@kevinlin12345
Copy link

@kevinlin12345 kevinlin12345 commented Aug 9, 2019

DO NOT OPEN ISSUES/REQUESTS RELATING TO EXTENSIONS/CATALOGUES IN THIS REPOSITORY. Open them at the following repository https://github.com/inorichi/tachiyomi-extensions/

For all other requests Please fill out the form below and remove the first 3 lines of this template

App version: 0.8.4

Android version: 9 (Samsung S10e)

Issue/Request: Downloaded + Unread badge are inaccurate

Steps to reproduce (if applicable)

I noticed that when downloading a large number of chapters, the unread and downloaded badge don't match up. For example, I was downloading all 158 chapters of Kaguya-sama, but the download badge says I only have 114 downloaded chapters and 118 unread chapters, both of which aren't correct. When I click on the manga, it shows all 158 chapters and says each are downloaded.

  1. Select a manga with many chapters, e.g. Kaguya-sama from MangaDex
  2. Choose download all
  3. Unread and downloaded badges don't match
@Silwyn

This comment has been minimized.

Copy link

@Silwyn Silwyn commented Aug 11, 2019

If two chapters have the same name, as sometime the case at MangaDex due to by different groups, then only chapter gets downloaded. Then all chapters of that title get marked as downloaded but the download counter only increases by one. If you then choose any of those chapters you will always get the downloaded version, even if it would differ.

You might argue that this should not be the expected behaviour, but thats how it is. I assume this is due to how downloaded chapters are referenced in the storage. In other words chapters with the same name will reference the same folder and therefore are considered downloaded.

TLDR: Number of downloaded chapters correct due to all chapters of the same name being declared downloaded if one of them has been downloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.