Add some comments to assembler.c #1
Closed
Conversation
pablogsal
force-pushed the
pablogsal:better-code-generation
branch
from
7f967e6
to
06a7f4a
markshannon
force-pushed the
markshannon:better-code-generation
branch
from
b97c765
to
925ac6c
pablogsal
force-pushed the
pablogsal:better-code-generation
branch
from
06a7f4a
to
6144691
markshannon
force-pushed the
markshannon:better-code-generation
branch
3 times, most recently
from
bcf616d
to
f09a15f
markshannon
pushed a commit
that referenced
this pull request
Jun 22, 2020
```
Direct leak of 8 byte(s) in 1 object(s) allocated from:
#0 0x7f008bf19667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667)
#1 0x7f007a0bee4a in subprocess_fork_exec /home/heimes/dev/python/cpython/Modules/_posixsubprocess.c:774
python#2 0xe0305b in cfunction_call Objects/methodobject.c:546
```
Signed-off-by: Christian Heimes <christian@python.org>
markshannon
pushed a commit
that referenced
this pull request
Nov 23, 2020
* bpo-40791: Make compare_digest more constant-time. The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change #1 from https://bugs.python.org/issue40791 .)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Meanwhile I familiarise myself with the design, here is a first batch of comments that will help reading the source in the future.