Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix openblas msvc export library generation #11
Merged
Conversation
…rary The name of the generated export file seems to have been changed from libopenblas.def to $(LIBPREFIX).def in OpenBLAS, probably in their commit dddedbab
|
This looks helpful & Appveyor CI logs look clear of the issue here, thanks Pauli. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The command building .lib export library on MSVC seems to be currently failing.
This does not seem to be new, see e.g. https://ci.appveyor.com/project/matthew-brett/openblas-libs/builds/26629867/job/2i2y96hhfgwlpjb3 from some months ago, where there is "LINK : fatal error LNK1104: cannot open file 'libopenblas_v0.3.7-gcc_7_1_0.def'" close to the end, and the generated .zip artifact is missing the msvc .lib and .def files.
It was fixed that for the INTERFACE64=1 case in #8, but I left the other case alone assuming it was different for some reason --- but it seems it has been broken. Numpy et al. don't need these files for building (due to the way numpy.distutils handles gfortran compatibility), so it's not particularly urgent.
Also, add
set -eflag to the bash build scripts, so that failures like this become fatal.