Created on 2019-11-21 11:22 by Linus Pithan, last changed 2019-11-24 20:45 by alexandre.vassalotti. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 17335 | merged | Claudiu.Popa, 2019-11-22 10:00 | |
| Messages (3) | |||
|---|---|---|---|
| msg357159 - (view) | Author: Linus Pithan (Linus Pithan) | Date: 2019-11-21 11:22 | |
When unpickling fails one would expect a pickle.UnpicklingError exception or at least a PickleError. However, when trying pickle.loads(b"jens:") it fails with KeyError: 980643429 which is not the wanted behaviour. |
|||
| msg357167 - (view) | Author: PCManticore (Claudiu.Popa) *  |
Date: 2019-11-21 13:08 | |
It seems there are a couple of places in `_pickle.c` where we favour a `KeyError` instead of `UnpicklingError` such as https://github.com/python/cpython/blob/master/Modules/_pickle.c#L6178. From a quick debugging it seems it originates in `load_long_binget`. Ideally those places should return `UnpicklingError` instead, not sure why a `KeyError` was preferred. Happy to submit a patch if that's a change that makes sense. |
|||
| msg357408 - (view) | Author: miss-islington (miss-islington) | Date: 2019-11-24 19:15 | |
New changeset 6f03b236c17c96bc9f8a004ffa7e7ae0542e9cac by Miss Islington (bot) (Claudiu Popa) in branch 'master': bpo-38876: Raise pickle.UnpicklingError when loading an item from memo for invalid input (GH-17335) https://github.com/python/cpython/commit/6f03b236c17c96bc9f8a004ffa7e7ae0542e9cac |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2019-11-24 20:45:53 | alexandre.vassalotti | set | status: open -> closed assignee: alexandre.vassalotti stage: patch review -> resolved resolution: fixed versions: - Python 3.7, Python 3.8 |
| 2019-11-24 19:15:11 | miss-islington | set | nosy:
+ miss-islington messages: + msg357408 |
| 2019-11-22 10:00:59 | Claudiu.Popa | set | keywords:
+ patch stage: patch review pull_requests: + pull_request16819 |
| 2019-11-21 13:08:15 | Claudiu.Popa | set | nosy:
+ Claudiu.Popa messages: + msg357167 |
| 2019-11-21 11:26:37 | BTaskaya | set | nosy:
+ alexandre.vassalotti, BTaskaya versions: + Python 3.8, Python 3.9 |
| 2019-11-21 11:22:59 | Linus Pithan | create | |