Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace matchAccount() with MatchAccount() #56
Merged
Conversation
When we originally added `MatchAccount()` in PR #24 to canonicalize email addresses in terms of case and remove dots in Gmail addresses, ironically, we did not remove a similarly-named local function `matchAccount()` (note the case difference), which has created some subtle problems in not validating some commits where the case of the email in the commit does not match the case of the email in the CLA. Removing the now-outdated `matchAccount()` and replacing its uses with `MatchAccount()` everywhere fixes this, and also adds the missing canonicalization of GitHub account IDs. Fixes #55
mbrukman
merged commit c523a05
into
google:master
2 checks passed
2 checks passed
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrukman commentedDec 15, 2019
When we originally added
MatchAccount()in PR #24 to canonicalizeemail addresses in terms of case and remove dots in Gmail addresses,
ironically, we did not remove a similarly-named local function
matchAccount()(note the case difference), which has created somesubtle problems in not validating some commits where the case of the
email in the commit does not match the case of the email in the CLA.
Removing the now-outdated
matchAccount()and replacing its uses withMatchAccount()everywhere fixes this, and also adds the missingcanonicalization of GitHub account IDs.
Fixes #55