[2.7] bpo-25083: Python 2 can sometimes create incorrect .pyc files #8449
Conversation
|
backport-pr is failing, because this is a Python 2 only issue. |
methane
changed the title
|
This looks good except for the use of |
|
And don't worry about the backport title check; that's for the person who'll merge this. |
|
Done. |
|
Here is a script to check for the bug: |
Parser/tokenizer.c
Outdated
| @@ -1681,6 +1681,10 @@ int | |||
| PyTokenizer_Get(struct tok_state *tok, char **p_start, char **p_end) | |||
| { | |||
| int result = tok_get(tok, p_start, p_end); | |||
| if (tok->fp && ferror(tok->fp)) { | |||
| result = ERRORTOKEN; | |||
| tok->done = E_IO; | |||
There was a problem hiding this comment.
Hum, should we call clearerr() here? In case if fp is used again.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Python 2 never checked for I/O error when reading .py files and thus could mistake an I/O error for EOF and create incorrect .pyc files. This adds an check for this and aborts on an error.
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
|
@encukou I'm waiting for the convincing part :) I think it's best to merge this ASAP (if it's plan to be used), so it has maximum exposure before a new release. |
Python 2 never checked for I/O error when reading .py files and
thus could mistake an I/O error for EOF and create incorrect .pyc
files. This adds an check for this and aborts on an error.
https://bugs.python.org/issue25083