Skip to content

/ peps

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 587: PyConfig_InitPythonConfig() cannot fail anymore #1187

Merged
merged 1 commit into from Oct 1, 2019
Merged

PEP 587: PyConfig_InitPythonConfig() cannot fail anymore #1187

merged 1 commit into from Oct 1, 2019

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 1, 2019

PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no
longer return PyStatus: they cannot fail anymore.
@vstinner
PEP 587: PyConfig_InitPythonConfig() cannot fail anymore
Loading status checks…
25a15b9 
PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no
longer return PyStatus: they cannot fail anymore.
@vstinner
Copy link
Member Author

@vstinner vstinner commented Oct 1, 2019

See python/cpython#16509 :

I forgot to update PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() in my PR #16500. There is no more need to return PyStatus since these functions cannot fail anymore. They don't allocate any memory: strings are initialized to NULL, lists to empty lists (which doesn't allocate any memory).
@vstinner
Copy link
Member Author

@vstinner vstinner commented Oct 1, 2019

cc @ncoghlan @ambv
@vstinner vstinner merged commit 06fbcf5 into python:master Oct 1, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vstinner vstinner deleted the vstinner:pyconfig_init branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@vstinner @the-knights-who-say-ni