Skip to content

/ readthedocs.org

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DOCKER_NORELOAD to compose settings #6461

Merged
merged 2 commits into from Dec 17, 2019
Merged

Add DOCKER_NORELOAD to compose settings #6461

merged 2 commits into from Dec 17, 2019

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Dec 16, 2019

This stops containers from auto-reloading.
@ericholscher
Add DOCKER_NORELOAD to compose settings
Loading status checks…
1458c48 
This stops containers from auto-reloading.
@ericholscher ericholscher requested a review from humitos Dec 16, 2019
@ericholscher
Add tasks for no-reload
Loading status checks…
a6a6065
@humitos
humitos reviewed Dec 16, 2019
View changes
Copy link
Member

@humitos humitos left a comment

Looks good to me. I haven't tested but it follow the same idea as the INIT variable.

My feedback on this would be to split DOCKER_NO_RELOAD into DJANGO_NO_RELOAD and CELERY_NO_RELOAD. I think that most of us will benefit of using CELERY_NO_RELOAD but maybe not from DJANGO_NO_RELOAD: there is no need to reload celery when working on serving docs stuff --which I think is the most common case.

It could also be a third argument called just --no-reload that enables both as a shortcut: celery and django.

Besides, if you think that this is not needed, I would call the variable just NO_RELOAD since the DOCKER_ part does not add meaning.
@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Dec 17, 2019

I think the DOCKER is because it's for docker-compose. I think it's useful to prefix it, could also do RTD_NO_RELOAD but I think this is fine for now.
@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Dec 17, 2019

I think this works for me for now, as it saves my CPU from burning up, we can make it cleaner as we go. 👍
@ericholscher ericholscher merged commit 3639eb1 into master Dec 17, 2019
3 checks passed
3 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@ericholscher ericholscher deleted the docker-cleanup branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ericholscher @humitos
You can’t perform that action at this time.