Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser-policy README mentions that "eval" is disabled by default #10705

Open
mitar opened this issue Sep 23, 2019 · 0 comments

Comments

@mitar
Copy link
Collaborator

commented Sep 23, 2019

On Meteor 1.8.1 this is maybe true for browser-policy package, but it is not really true for any realistic Meteor app these days because apps use ecmascript which requires dynamic-import, which enabled eval by default. So in practice, by default, eval is enabled. See #10704.

It should be probably clarified in the README that the package by default keeps it disabled, but Meteor apps by default enable it because of dynamic-import and that you should remove dynamic-import package if you want to get it disabled (I hope that resolution of #10704 will be that one can remove dynamic-import).

See: https://github.com/meteor/meteor/tree/devel/packages/browser-policy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.