Skip to content

bpo-34293: fix DOC Makefile regarding PAPER envvar#8585

Merged
zware merged 2 commits into
python:masterfrom
jfbu:doc_fix_Makefile_PAPER
Sep 9, 2019
Merged

bpo-34293: fix DOC Makefile regarding PAPER envvar#8585
zware merged 2 commits into
python:masterfrom
jfbu:doc_fix_Makefile_PAPER

Conversation

@jfbu

@jfbu jfbu commented Jul 31, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@jfbu

jfbu commented Jul 31, 2018

Copy link
Copy Markdown
Contributor Author

The problem fixed here shows when accessing https://docs.python.org/3/download.html today (July 31, 2018) and downloading https://docs.python.org/3/archives/python-3.7.0-docs-pdf-a4.zip. Opening the PDF files in a PDF viewer, one confirms they are for letter, not A4 paper size.

@jfbu jfbu mentioned this pull request Jul 31, 2018
Closed
zware
zware reviewed Jul 31, 2018
View reviewed changes
Comment thread Doc/Makefile Outdated
zware
zware approved these changes Sep 9, 2019
View reviewed changes

@zware zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zware zware force-pushed the doc_fix_Makefile_PAPER branch from de3d35c to 06e6376 Compare September 9, 2019 16:56
@zware zware merged commit b5381f6 into python:master Sep 9, 2019
@zware

zware commented Sep 9, 2019

Copy link
Copy Markdown
Member

Thank you for the patch, sorry it took so long to get it merged!

@miss-islington

miss-islington commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

Thanks @jfbu for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

Thanks @jfbu for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

Sorry, @jfbu and @zware, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b5381f669718aa19690f42f3b8bd88f03045b9d2 3.7

@miss-islington

miss-islington commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

Sorry @jfbu and @zware, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker b5381f669718aa19690f42f3b8bd88f03045b9d2 3.8

zware pushed a commit to zware/cpython that referenced this pull request Sep 9, 2019
@jfbu @zware
[3.8] bpo-34293: Fix PDF documentation paper size (pythonGH-8585)
16ca8d9 
The "A4" pdfs were previously the wrong size due to a change in the options in Sphinx 1.5.

See also sphinx-doc/sphinxGH-5235
(cherry picked from commit b5381f6)

Co-authored-by: Jean-François B <jfbu@free.fr>
@bedevere-bot

bedevere-bot commented Sep 9, 2019

Copy link
Copy Markdown

GH-15816 is a backport of this pull request to the 3.8 branch.

zware pushed a commit to zware/cpython that referenced this pull request Sep 9, 2019
@jfbu @zware
[3.7] bpo-34293: Fix PDF documentation paper size (pythonGH-8585)
0e8ff00 
The "A4" pdfs were previously the wrong size due to a change in the options in Sphinx 1.5.

See also sphinx-doc/sphinxGH-5235.
(cherry picked from commit b5381f6)

Co-authored-by: Jean-François B <jfbu@free.fr>
@bedevere-bot

bedevere-bot commented Sep 9, 2019

Copy link
Copy Markdown

GH-15817 is a backport of this pull request to the 3.7 branch.

zware added a commit that referenced this pull request Sep 9, 2019
@zware
[3.8] bpo-34293: Fix PDF documentation paper size (GH-8585) (GH-15816)
99df5e8 
The "A4" pdfs were previously the wrong size due to a change in the options in Sphinx 1.5.

See also sphinx-doc/sphinxGH-5235
(cherry picked from commit b5381f6)

Authored-by: Jean-François B <jfbu@free.fr>
zware added a commit that referenced this pull request Sep 9, 2019
@zware
[3.7] bpo-34293: Fix PDF documentation paper size (GH-8585) (GH-15817)
12228ce 
The "A4" pdfs were previously the wrong size due to a change in the options in Sphinx 1.5.

See also sphinx-doc/sphinxGH-5235.
(cherry picked from commit b5381f6)

Authored-by: Jean-François B <jfbu@free.fr>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@jfbu @websurfer5
bpo-34293: Fix PDF documentation paper size (pythonGH-8585)
681a0d4 
The "A4" pdfs were previously the wrong size due to a change in the options in Sphinx 1.5.

See also sphinx-doc/sphinx#5235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes

Assignees

@zware zware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jfbu @zware @miss-islington @bedevere-bot @the-knights-who-say-ni