Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] bpo-33954: Fix _PyUnicode_InsertThousandsGrouping() (GH-10623) #10718

Merged
merged 1 commit into from Nov 26, 2018

Conversation

@vstinner
Copy link
Member

commented Nov 26, 2018 •
edited by bedevere-bot

Fix str.format(), float.format() and complex.format() methods
for non-ASCII decimal point when using the "n" formatter.

Rewrite _PyUnicode_InsertThousandsGrouping(): it now requires
a _PyUnicodeWriter object for the buffer and a Python str object
for digits.

(cherry picked from commit 59423e3)

https://bugs.python.org/issue33954
@vstinner
bpo-33954: Fix _PyUnicode_InsertThousandsGrouping() (GH-10623) 
Fix str.format(), float.__format__() and complex.__format__() methods
for non-ASCII decimal point when using the "n" formatter.

Rewrite _PyUnicode_InsertThousandsGrouping(): it now requires
a _PyUnicodeWriter object for the buffer and a Python str object
for digits.

(cherry picked from commit 59423e3)
Loading status checks…
eff7902

@bedevere-bot bedevere-bot added the type-bugfix label Nov 26, 2018

@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 26, 2018

@bedevere-bot bedevere-bot added the awaiting merge label Nov 26, 2018

@vstinner vstinner referenced this pull request Nov 26, 2018
Closed

@vstinner vstinner added the needs backport to 3.6 label Nov 26, 2018

@vstinner vstinner merged commit 6f5fa1b into python:3.7 Nov 26, 2018
5 of 6 checks passed

5 of 6 checks passed

Azure Pipelines PR #20181126.18 failed
Details
bedevere/issue-number Issue number 33954 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

commented Nov 26, 2018

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the awaiting merge label Nov 26, 2018

@miss-islington

This comment has been minimized.

Sign in to view
Copy link

commented Nov 26, 2018

Sorry, @vstinner, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6f5fa1b4be735159e964906ab608dc467476e47c 3.6

@miss-islington miss-islington assigned vstinner Nov 26, 2018

@vstinner vstinner deleted the vstinner:insert_thousands37 branch Nov 26, 2018

@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

commented Nov 26, 2018

GH-10720 is a backport of this pull request to the 3.6 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Nov 26, 2018

vstinner added a commit to vstinner/cpython that referenced this pull request Nov 26, 2018
@vstinner
bpo-33954: Fix _PyUnicode_InsertThousandsGrouping() (pythonGH-10623) (p… 
…ythonGH-10718)

Fix str.format(), float.__format__() and complex.__format__() methods
for non-ASCII decimal point when using the "n" formatter.

Rewrite _PyUnicode_InsertThousandsGrouping(): it now requires
a _PyUnicodeWriter object for the buffer and a Python str object
for digits.

(cherry picked from commit 59423e3)
(cherry picked from commit 6f5fa1b)
fe6778b
vstinner added a commit that referenced this pull request Nov 26, 2018
@vstinner
bpo-33954: Fix _PyUnicode_InsertThousandsGrouping() (GH-10623) (GH-10718 
) (GH-10720)

Fix str.format(), float.__format__() and complex.__format__() methods
for non-ASCII decimal point when using the "n" formatter.

Rewrite _PyUnicode_InsertThousandsGrouping(): it now requires
a _PyUnicodeWriter object for the buffer and a Python str object
for digits.

(cherry picked from commit 59423e3)
(cherry picked from commit 6f5fa1b)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fc4a44b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vstinner vstinner

Labels
CLA signed type-bugfix
Projects
None yet
Milestone
No milestone
4 participants
@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni
You can’t perform that action at this time.