Skip to content

/ Java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: MaxHeap.toggleUp should determine if there is a parent node. #775

Open
MrHeer opened this issue Jun 3, 2019 · 1 comment
Open

bug: MaxHeap.toggleUp should determine if there is a parent node. #775

MrHeer opened this issue Jun 3, 2019 · 1 comment

Comments

@MrHeer
Copy link

@MrHeer MrHeer commented Jun 3, 2019

Java/DataStructures/Heaps/MaxHeap.java

Lines 49 to 56 in 990b88f

// Toggle an element up to its right place as long as its key is lower than its parent's
private void toggleUp(int elementIndex) {
double key = maxHeap.get(elementIndex - 1).getKey();
while (getElementKey((int) Math.floor(elementIndex / 2)) < key) {
swap(elementIndex, (int) Math.floor(elementIndex / 2));
elementIndex = (int) Math.floor(elementIndex / 2);
}
}

should determine if there is a parent node while looping. Like this:

while ((int) Math.floor(elementIndex / 2) > 0 && getElementKey((int) Math.floor(elementIndex / 2)) < key) {
    ......
}
@1170500820
Copy link

@1170500820 1170500820 commented Jul 13, 2019

I am working on this issue.
@1170300825 1170300825 mentioned this issue Jul 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@MrHeer @1170500820
You can’t perform that action at this time.