Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uphopper: fix libxml2 dynamic linking issue #75522
Merged
Conversation
* port to qt5.callPackage / mkDerivation * format derivation
* use wrapQtAppsHook in favour for the custom qt builder * use autoPatchelfHook * cleanup build dependencies * add maintainer Enteee
| maintainers = [ stdenv.lib.maintainers.luis ]; | ||
| platforms = stdenv.lib.platforms.linux; | ||
| license = licenses.unfree; | ||
| maintainers = [ |
jtojnar
Dec 11, 2019
Contributor
Why not use with maintainers
Why not use with maintainers
Enteee
Dec 15, 2019
Author
Contributor
done
done
| python27, | ||
| gmpxx, | ||
| }: | ||
| let |
jtojnar
Dec 11, 2019
Contributor
Empty let.
Empty let.
Enteee
Dec 15, 2019
Author
Contributor
done
done
|
|
||
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| mkdir -p $out/lib | ||
| mkdir -p $out/share | ||
| cp $sourceRoot/opt/hopper-${rev}/bin/Hopper $out/bin/hopper | ||
| cp -r $sourceRoot/opt/hopper-${rev}/lib $out | ||
| cp -r $sourceRoot/usr/share $out/share |
jtojnar
Dec 11, 2019
Contributor
This is installing files into $out/share/share
This is installing files into $out/share/share
Enteee
Dec 15, 2019
Author
Contributor
done
done
|
|
||
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| mkdir -p $out/lib | ||
| mkdir -p $out/share | ||
| cp $sourceRoot/opt/hopper-${rev}/bin/Hopper $out/bin/hopper | ||
| cp -r $sourceRoot/opt/hopper-${rev}/lib $out |
jtojnar
Dec 11, 2019
Contributor
I do not like all these libraries being vendored, could you perhaps only copy those that are not available in nixpkgs and add the rest to buildInputs?
── lib
│ ├── libBlocksRuntime.so.0
│ ├── libdispatch.so -> libdispatch.so.1
│ ├── libdispatch.so.0.1.3.1
│ ├── libdispatch.so.1 -> libdispatch.so.0.1.3.1
│ ├── libform.so.5
│ ├── libgnustep-base.so -> libgnustep-base.so.1.24
│ ├── libgnustep-base.so.1.24 -> libgnustep-base.so.1.24.9
│ ├── libgnustep-base.so.1.24.9
│ ├── libHopperCore.so
│ ├── libkqueue.so.0
│ ├── libncurses.so.5
│ ├── libobjc.so -> libobjc.so.4.6
│ ├── libobjc.so.4.6
│ ├── libobjcxx.so -> libobjcxx.so.4.6
│ ├── libobjcxx.so.4.6
│ ├── libpthread_workqueue.so.0
│ └── libtinfo.so.5
I do not like all these libraries being vendored, could you perhaps only copy those that are not available in nixpkgs and add the rest to buildInputs?
── lib
│ ├── libBlocksRuntime.so.0
│ ├── libdispatch.so -> libdispatch.so.1
│ ├── libdispatch.so.0.1.3.1
│ ├── libdispatch.so.1 -> libdispatch.so.0.1.3.1
│ ├── libform.so.5
│ ├── libgnustep-base.so -> libgnustep-base.so.1.24
│ ├── libgnustep-base.so.1.24 -> libgnustep-base.so.1.24.9
│ ├── libgnustep-base.so.1.24.9
│ ├── libHopperCore.so
│ ├── libkqueue.so.0
│ ├── libncurses.so.5
│ ├── libobjc.so -> libobjc.so.4.6
│ ├── libobjc.so.4.6
│ ├── libobjcxx.so -> libobjcxx.so.4.6
│ ├── libobjcxx.so.4.6
│ ├── libpthread_workqueue.so.0
│ └── libtinfo.so.5
Enteee
Dec 15, 2019
•
Author
Contributor
- libBlocksRuntime.so.0
- copy
- libdispatch.so.0.1.3.1
- copy
- libform.so.5
- copy
- ncurses5.out
- (gcc-arm-embedded-4_9.out)
- (androidStudioPackages.dev.out)
- (androidStudioPackages.canary.out)
- (android-studio.out)
- (androidStudioPackages.beta.out)
- libgnustep-base.so.1.24.9
- copy
- libHopperCore.so
- copy
- libkqueue.so.0
- copy
- libncurses.so.5
- copy
- scilab-bin.out
- ncurses5.out
- (gcc-arm-embedded-4_9.out)
- (androidStudioPackages.dev.out)
- (androidStudioPackages.canary.out)
- (android-studio.out)
- (androidStudioPackages.beta.out)
- libobjc.so.4.6
- copy
- gnustep.libobjc.out
- libobjcxx.so.4.6
- copy
- libpthread_workqueue.so.0
- copy
- libtinfo.so.5
- copy
- tlf.out
- ncurses5.out
- (gcc-arm-embedded-4_9.out)
- jetbrains.clion.out
- arduino-core.out
- arduino.out
- (androidStudioPackages.dev.out)
- (androidStudioPackages.canary.out)
- (android-studio.out)
- (androidStudioPackages.beta.out)
generated with:
for l in *; do [ -L "${l}" ] && continue; echo "* ${l}"; echo " - [ ] copy"; nix-locate -1 -w "${l}" | sed -e 's/^/ - [ ] /' ; done | xclip
- libBlocksRuntime.so.0
- copy
- libdispatch.so.0.1.3.1
- copy
- libform.so.5
- copy
- ncurses5.out
- (gcc-arm-embedded-4_9.out)
- (androidStudioPackages.dev.out)
- (androidStudioPackages.canary.out)
- (android-studio.out)
- (androidStudioPackages.beta.out)
- libgnustep-base.so.1.24.9
- copy
- libHopperCore.so
- copy
- libkqueue.so.0
- copy
- libncurses.so.5
- copy
- scilab-bin.out
- ncurses5.out
- (gcc-arm-embedded-4_9.out)
- (androidStudioPackages.dev.out)
- (androidStudioPackages.canary.out)
- (android-studio.out)
- (androidStudioPackages.beta.out)
- libobjc.so.4.6
- copy
- gnustep.libobjc.out
- libobjcxx.so.4.6
- copy
- libpthread_workqueue.so.0
- copy
- libtinfo.so.5
- copy
- tlf.out
- ncurses5.out
- (gcc-arm-embedded-4_9.out)
- jetbrains.clion.out
- arduino-core.out
- arduino.out
- (androidStudioPackages.dev.out)
- (androidStudioPackages.canary.out)
- (android-studio.out)
- (androidStudioPackages.beta.out)
generated with:
for l in *; do [ -L "${l}" ] && continue; echo "* ${l}"; echo " - [ ] copy"; nix-locate -1 -w "${l}" | sed -e 's/^/ - [ ] /' ; done | xclip
Enteee
Dec 15, 2019
Author
Contributor
done
done
* add dependency to ncurses, gnustep * don't copy to share/share * run pre/post Install hooks * fix desktop icon * with maintainers
|
@jtojnar all review comments were implemented, please merge. |
|
Tested and works fine :-) |
Mic92
merged commit 2d87562
into
NixOS:master
15 checks passed
15 checks passed
grahamcofborg-eval-darwin
nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos
nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual
nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options
nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual
nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball
nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset
nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list-no-aliases
nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
dtzWill
added a commit
to dtzWill/nixpkgs
that referenced
this pull request
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Motivation for this change
On channel:
nixpkgs-20.03pre202154.58fb23f72adhopper currently fails to start:Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @Luis-Hebendanz (Maintainer)
@ttuegel (Contributor)