Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Sync Fork from Upstream Repo #46
Merged
Conversation
…eolder (streamlit#714) * wip * Adding to state * Clean up * Maybe is working * cleanup * more cleanup * refactoring * move out reportState * minor cleanuo * test * fix linter * restoring viz * jslint * fixing margins * fixed problem with spaces and Maybe * tmp * wip * making Maybe the outer wrapper to correctly handle css class * Fixing test * factoring out to function * simplifying css
If `s3.url` is set in the user's config, ensure that it's an absolute URL. An absolute URL starts with either `scheme://` or `//` -- if the configured URL does not start with either prefix, prepend it with `//` to make it absolute. (If we don't do this, and the user enters something like `url=myhost.com/reports`, the browser will assume this is a relative URL, and will prepend the hostname of the Streamlit instance to the configured URL.) Fixes streamlit#802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Before contributing (PLEASE READ!)
This helps make sure (1) two people aren't working on the same thing, (2) this is something Streamlit's maintainers believe should be implemented/fixed, (3) any API, UI, or deeper architectural changes that need to be implemented have been fully thought through by Streamlit's maintainers.
More information in our wiki: https://github.com/streamlit/streamlit/wiki/Contributing
Issue: Please include a link to the issue you're addressing. If no issue exists, create one first and then link it here.
Description: Describe the changes you made to the code, so it's easier for the reader to navigate your pull request. Usually this is a bullet list.
Contribution License Agreement
By submiting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.