-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
english not move next column #2170
Comments
|
Yes that's a big I guess. Long lines should be wrapped in viewer too. Good first issue: it should be easy to implement by modifying the CSS in noteStyle.js |
|
@2jaeyeol @laurent22 I would like to work on it |
|
Thanks good @amitsin6h, if you need any help let me know. |
|
@laurent22 sorry for being late, I have fixed the issue. It was the webview loader that was causing the issue so I edited the index.html so that it wrap the content inside the view. |
|
@laurent22 also I think both have different font styles and the reason both views are not similar. Let me know if I can change the font or resize the font for the preview screen so it has a similar display. Or else I will send the PR for the current fix. Please let me know what to do next |
|
@laurent22 I am waiting for your reply so that we can close this issue |
|
Thanks for looking into it @amitsin6h. Please go ahead and create a pull request with the wrapping fix, but don't change font size as that should be discussed more in depth, possibly as part of a redesign of the app. |
|
@laurent22 please review my PR and also help me in resolving the conflict #2442 |
|
@laurent22 please review the updated PR #2447 |
|
@amitsin6h, I got three notifications to ask me to review this PR (2 from your comments, and 1 from review request). You don't need to send even one because I already get one when you create the PR, so please just don't send any notification. Your PR will be reviewed eventually when those involved have time. |
|
sorry for this will make sure I don't do such things again
…On Wed, Feb 5, 2020 at 11:34 PM Laurent Cozic ***@***.***> wrote:
@amitsin6h <https://github.com/amitsin6h>, I got three notifications to
ask me to review this PR (2 from your comments, and 1 from review request).
You don't need to send even one because I already get one when you create
the PR, so please just don't send any notification. Your PR will be
reviewed eventually when those involved have time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2170?email_source=notifications&email_token=ADCO42Q4XF4OCCK24I4LT7TRBL5ULA5CNFSM4JY7VYS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK4MXWY#issuecomment-582536155>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADCO42VZGFLI6MODJQ33T4LRBL5ULANCNFSM4JY7VYSQ>
.
|

Environment
Joplin version: 1.0.174

Platform:
OS specifcs: window10 64
Steps To Reproduce
Describe what you expected to happen:
english is not move next column when I not use spacebar or enter
when I write korean , there are move next column but not english
is that bug? if it is bug i want modify
Logfile
The text was updated successfully, but these errors were encountered: