Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

english not move next column #2170

Closed
2jaeyeol opened this issue Dec 10, 2019 · 11 comments
Closed

english not move next column #2170

2jaeyeol opened this issue Dec 10, 2019 · 11 comments
Labels
bug It's a bug

Comments

@2jaeyeol
Copy link
Contributor

Environment

Joplin version: 1.0.174
Platform:
OS specifcs: window10 64
bug

Steps To Reproduce

Describe what you expected to happen:
english is not move next column when I not use spacebar or enter
when I write korean , there are move next column but not english
is that bug? if it is bug i want modify

Logfile

@2jaeyeol 2jaeyeol added the bug It's a bug label Dec 10, 2019
@laurent22
Copy link
Owner

laurent22 commented Dec 15, 2019

Yes that's a big I guess. Long lines should be wrapped in viewer too.

Good first issue: it should be easy to implement by modifying the CSS in noteStyle.js

@amitsin6h
Copy link
Contributor

@2jaeyeol @laurent22 I would like to work on it

@laurent22
Copy link
Owner

Thanks good @amitsin6h, if you need any help let me know.

@amitsin6h
Copy link
Contributor

@laurent22 sorry for being late, I have fixed the issue. It was the webview loader that was causing the issue so I edited the index.html so that it wrap the content inside the view.

Screenshot from 2019-12-23 00-20-17

@amitsin6h
Copy link
Contributor

amitsin6h commented Dec 22, 2019

@laurent22 also I think both have different font styles and the reason both views are not similar. Let me know if I can change the font or resize the font for the preview screen so it has a similar display. Or else I will send the PR for the current fix.

Please let me know what to do next

@amitsin6h
Copy link
Contributor

@laurent22 I am waiting for your reply so that we can close this issue

@laurent22
Copy link
Owner

Thanks for looking into it @amitsin6h. Please go ahead and create a pull request with the wrapping fix, but don't change font size as that should be discussed more in depth, possibly as part of a redesign of the app.

@amitsin6h
Copy link
Contributor

@laurent22 please review my PR and also help me in resolving the conflict #2442

@amitsin6h
Copy link
Contributor

@laurent22 please review the updated PR #2447

@laurent22
Copy link
Owner

@amitsin6h, I got three notifications to ask me to review this PR (2 from your comments, and 1 from review request). You don't need to send even one because I already get one when you create the PR, so please just don't send any notification. Your PR will be reviewed eventually when those involved have time.

@amitsin6h
Copy link
Contributor

amitsin6h commented Feb 5, 2020 via email

@tessus tessus closed this as completed Feb 18, 2020
@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug It's a bug
Projects
None yet
Development

No branches or pull requests

4 participants