Replace uses of traits.api.Long with traits.api.Int #868
Conversation
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
==========================================
+ Coverage 50.85% 50.86% +<.01%
==========================================
Files 263 263
Lines 23846 23843 -3
Branches 3252 3251 -1
==========================================
Hits 12128 12128
+ Misses 10931 10928 -3
Partials 787 787
Continue to review full report at Codecov.
|
|
@rahulporuri @prabhuramachandran Would either of you be able to review? |
|
LGTM. |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR replaces uses of
LongwithInt.Intshould be an acceptable substitute anywhere thatLongis used. (On Python 2, theInttrait type acceptslonginstances since enthought/traits#104.)