Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
DNS install check: allow overlapping zone to be from the master itself #4001
Conversation
abbra
changed the title
|
@t-woerner is going to add a test of re-running |
This is only happening if domain is set explicitly in the command line installer as check_zone_overlap is used in the domain_name validator. |
t-woerner
force-pushed the
abbra:fix-installer-dns-zone-on-itself
branch
3 times, most recently
from
2bab584
to
15f7922
abbra
force-pushed the
abbra:fix-installer-dns-zone-on-itself
branch
from
15f7922
to
67b4b2a
abbra
force-pushed the
abbra:fix-installer-dns-zone-on-itself
branch
2 times, most recently
from
3bd6df5
to
0381531
abbra
force-pushed the
abbra:fix-installer-dns-zone-on-itself
branch
3 times, most recently
from
9969d1a
to
2daa5cd
abbra
force-pushed the
abbra:fix-installer-dns-zone-on-itself
branch
from
2daa5cd
to
eb81e7c
abbra
force-pushed the
abbra:fix-installer-dns-zone-on-itself
branch
from
eb81e7c
to
c92b8cb
abbra
force-pushed the
abbra:fix-installer-dns-zone-on-itself
branch
2 times, most recently
from
629bf46
to
7a52fd8
|
Tests succeeded, I removed temp commit. |
When re-running `ipa-server-install --setup-dns` on already installed server, we do not get to the check of being already installed because DNS zone overlap forces us to fail earlier. Change exception returned for this case from check_zone_overlap() to return structured information that allows to understand whether we are finding a conflict with ourselves. Use the returned information to only fail DNS check at this point if DNS zone overlap is generated by a different name server than ourselves.
… set Test that a repeated installation of the primary with DNS enabled will lead to a already installed message and not in "DNS zone X already exists in DNS" in check_zone_overlap. The error is only occuring if domain is set explicitly in the command line installer as check_zone_overlap is used in the domain_name validator.
For fedora-latest, pki-fedora, fedora-previous and fedora-rawhide
abbra
force-pushed the
abbra:fix-installer-dns-zone-on-itself
branch
from
7a52fd8
to
478cf98
|
This was missing a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When re-running
ipa-server-install --setup-dnson already installedserver, we do not get to the check of being already installed because
DNS zone overlap forces us to fail earlier.
Change exception returned for this case from check_zone_overlap() to
return structured information that allows to understand whether we are
finding a conflict with ourselves.
Use the returned information to only fail DNS check at this point if DNS
zone overlap is generated by a different name server than ourselves.