Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up0.4.9 release seems to break tokio (which depends on log) #369
Comments
|
I am receiving similar errors trying to install cargo-make.
|
|
It seems to break |
|
This also breaks |
|
I've yanked the 0.4.9 release. @KodrAus It looks like all of the code blocks in the log_impl macro need to be contained in a block - how did CI pass after the KV stuff landed? |
|
Install cargo-make is working again, thank you for the very quick fix! |
|
@sfackler Hm that's a good question... I'll check this out now. |
|
Ok, it looks like with our macro tests being brand new we didn't have coverage for the macros in expression context so CI didn't pick this up. I also totally missed this when reviewing the original implementation. I'm putting together a PR now to fix this up. |
|
I've just published |
You can see an example of this here: https://github.com/alex/otp-cop/pull/374/checks?check_run_id=349720268
I didn't see a mention of breaking changes (besides MSRV) in the CHANGELOG, so I'm filing this here. Let me know if this should be filed on tokio instead though!