Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for the std::bigint scalar type #52
Merged
Conversation
edgedb-clabot
commented
Dec 2, 2019
•
`std::bigint` is an explicit variant of a numeric with zero fractional scale. It is an error to pass any value with fractional part as an argument to a query accepting `bigint`. I also took an opportunity to clean up and organize client-side argument validation error reporting. Invalid argument values now consistently raise `InvalidArgumentValueError` which includes information on which argument is problematic, as well as an excerpt from the value repr().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
elprans commentedDec 1, 2019
std::bigintis an explicit variant of a numeric with zero fractionalscale. It is an error to pass any value with fractional part as an
argument to a query accepting
bigint.I also took an opportunity to clean up and organize client-side argument
validation error reporting. Invalid argument values now consistently
raise
InvalidArgumentValueErrorwhich includes information on whichargument is problematic, as well as an excerpt from the value repr().