Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the std::bigint scalar type #52

Merged
merged 1 commit into from Dec 2, 2019
Merged

Add support for the std::bigint scalar type #52

merged 1 commit into from Dec 2, 2019

Conversation

@elprans
Copy link
Member

elprans commented Dec 1, 2019

std::bigint is an explicit variant of a numeric with zero fractional
scale. It is an error to pass any value with fractional part as an
argument to a query accepting bigint.

I also took an opportunity to clean up and organize client-side argument
validation error reporting. Invalid argument values now consistently
raise InvalidArgumentValueError which includes information on which
argument is problematic, as well as an excerpt from the value repr().

@elprans elprans requested a review from 1st1 Dec 1, 2019
edgedb/protocol/codecs/codecs.pyx Outdated Show resolved Hide resolved
edgedb/protocol/codecs/codecs.pyx Outdated Show resolved Hide resolved
@elprans elprans force-pushed the bigint branch 3 times, most recently from bef2dcf to 67b51ca Dec 2, 2019
edgedb/__init__.py Outdated Show resolved Hide resolved
edgedb/protocol/codecs/codecs.pyx Outdated Show resolved Hide resolved
@elprans elprans force-pushed the bigint branch 2 times, most recently from 36989fb to 9cdbc22 Dec 2, 2019
@edgedb-clabot
Copy link

edgedb-clabot commented Dec 2, 2019

CLA assistant check
All committers have signed the CLA.

@1st1
1st1 approved these changes Dec 2, 2019
`std::bigint` is an explicit variant of a numeric with zero fractional
scale.  It is an error to pass any value with fractional part as an
argument to a query accepting `bigint`.

I also took an opportunity to clean up and organize client-side argument
validation error reporting.  Invalid argument values now consistently
raise `InvalidArgumentValueError` which includes information on which
argument is problematic, as well as an excerpt from the value repr().
@elprans elprans force-pushed the bigint branch from 9cdbc22 to 1749a99 Dec 2, 2019
@elprans elprans merged commit 1749a99 into master Dec 2, 2019
1 of 7 checks passed
1 of 7 checks passed
test (3.6, ubuntu-16.04) test (3.6, ubuntu-16.04)
Details
test (3.6, macos-10.14) test (3.6, macos-10.14)
Details
test (3.7, ubuntu-16.04) test (3.7, ubuntu-16.04)
Details
test (3.7, macos-10.14) test (3.7, macos-10.14)
Details
test (3.8, ubuntu-16.04)
Details
test (3.8, macos-10.14)
Details
license/cla Contributor License Agreement is signed.
Details
@elprans elprans deleted the bigint branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.