Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix int to size_t comparison by casting int to size_t #150

Merged
merged 1 commit into from Dec 16, 2019

Conversation

@isidentical
Copy link
Contributor

@isidentical isidentical commented Dec 15, 2019

(.venv) [ 10:00ÖÖ ]  [ isidentical@x200:~/pycraft(master✔) ]
 $ python setup.py build
running build
running build_ext
building 'render_c' extension
creating build
creating build/temp.linux-x86_64-3.9-pydebug
gcc -pthread -Wno-unused-result -Wsign-compare -g -Og -Wall -fPIC -I/home/isidentical/.venv/include -I/usr/local/include/python3.9d -c render_c_module.c -o build/temp.linux-x86_64-3.9-pydebug/render_c_module.o
render_c_module.c: In function ‘render_map’:
render_c_module.c:1026:31: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
 1026 |         if (n_wprintf_written != frame.cur_pos)
      |                               ^~
@olls olls merged commit ce301b9 into itsapi:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.