Skip to content
One framework. Mobile & desktop.
TypeScript JavaScript HTML Python CSS Shell
Branch: master
Clone or download
devversion and kara feat(forms): expand NgModel disabled type to work with strict templat…
…e type checking (#34438)

NgModel internally coerces any arbitrary value that will assigned
to the `disabled` `@Input` to a boolean. This has been done to
support the common case where developers set the disabled attribute
without a value. For example:

```html
<input type="checkbox" [(ngModel)]="value" disabled>
```

This worked in View Engine without any errors because inputs were
not strictly checked. In Ivy though, developers can opt-in into
strict template type checking where the attribute would be flagged.

This is because the `NgModel#isDisabled` property type-wise only
accepts a `boolean`. To ensure that the common pattern described
above can still be used, and to reflect the actual runtime behavior,
we should add an acceptance member that makes it work without type
checking errors.

Using a coercion member means that this is not a breaking change.

PR Close #34438
Latest commit 5cecd97 Dec 16, 2019
Permalink
Type Name Latest commit message Commit time
Failed to load latest commit information.
.circleci ci: fix saucelabs_view_engine master-only failing (#34429) Dec 16, 2019
.devcontainer docs: add info on setting up VSCode remote development using docker c… Nov 13, 2019
.github ci: fix code ownership for size tracking (#34044) Nov 26, 2019
.vscode build: migrate references and scripts that set to build with ivy via … Nov 26, 2019
aio build: update to yarn@1.21.1 (#34384) Dec 16, 2019
docs build: migrate references and scripts that set to build with ivy via … Nov 26, 2019
integration build: remove unused `polyfills-runtime.ts` file (#34424) Dec 16, 2019
modules perf: rename index to index_aot (#34258) Dec 5, 2019
packages feat(forms): expand NgModel disabled type to work with strict templat… Dec 16, 2019
scripts ci: run acceptance tests on saucelabs with ivy (#34277) Dec 16, 2019
third_party build: update to yarn@1.21.1 (#34384) Dec 16, 2019
tools feat(forms): expand NgModel disabled type to work with strict templat… Dec 16, 2019
.bazelignore build: add integration/platform-server/node_modules to .bazelignore (#… Nov 22, 2019
.bazelrc build: remove remaining internal references to define=compile flag (#… Nov 26, 2019
.clang-format feat(tooling): Add a .clang-format for automated JavaScript formatting. Apr 2, 2015
.editorconfig build: use https link to editorconfig.org in .editorconfig (#27664) Dec 18, 2018
.gitattributes test: fix ts api guardian and public guard tests on windows (#30105) Apr 26, 2019
.gitignore feat: add direction property to locale files (#33556) Dec 3, 2019
.mailmap build: add a Git .mailmap with my new name (#19550) Oct 9, 2017
.nvmrc build: update .nvmrc to correct node version (#33636) Nov 6, 2019
BUILD.bazel ci: run acceptance tests on saucelabs with ivy (#34277) Dec 16, 2019
CHANGELOG.md docs: release notes for the v9.0.0-rc.6 release Dec 11, 2019
CODE_OF_CONDUCT.md docs: fix community tab in GitHub by copying CoC Feb 28, 2018
CONTRIBUTING.md docs: add missing parenthesis (#31041) Oct 7, 2019
LICENSE build: bump year (#27880) Jan 11, 2019
README.md docs: fix typo of Typescript to TypeScript (#32153) Aug 15, 2019
WORKSPACE build: update to yarn@1.21.1 (#34384) Dec 16, 2019
browser-providers.conf.js ci: re-enable chrome mobile tests on android (#32447) Sep 3, 2019
gulpfile.js build: remove obsolete build related tools and helper scripts (#34058) Dec 2, 2019
karma-js.conf.js ci: ensure saucelabs test output is human readable (#34277) Dec 16, 2019
package.json build: update to yarn@1.21.1 (#34384) Dec 16, 2019
protractor-perf.conf.js fixup! test(ivy): make the test run with benchpress (#30449) May 17, 2019
shims_for_IE.js Revert "refactor: add license header to JS files & format files (#12035 Oct 4, 2016
test-events.js refactor: rename unpatched event flag in Zone from `BLACK_LISTED_EVEN… Oct 4, 2019
test-main.js feat(ivy): i18n - implement compile-time inlining (#32881) Oct 9, 2019
tslint.json style: enforce disallowance of object constructor (#33211) Dec 3, 2019
yarn.lock build: remove unused webpack npm dependency (#34366) Dec 12, 2019
yarn.lock.readme.md build: remove travisci leftovers (#27979) Jan 9, 2019

README.md

You can’t perform that action at this time.