Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[WIP] Support direct connectivity to cluster nodes and simplify SSH configuration #397
Conversation
snh
changed the title
Unifies the approach taken by the backup scripts (which doesn't get the hostname from the command-line), and restore (which do).
| @@ -75,7 +60,7 @@ for hostname in $hostnames; do | |||
|
|
|||
| # Transfer all data from the user data directory using rsync. | |||
| ghe-rsync -avz \ | |||
| -e "ssh -q $opts -p $port $ssh_config_file_opt -l $user" \ | |||
| -e "ghe-ssh" \ | |||
buckelij
Jun 11, 2018
Member
This is great ✨ . $port is currently derived from ssh_port_part, which returns port 22 by default. Switching this to ghe-ssh will prevent some cases where ghe-backup-pages (and some other scripts) try to connect to the wrong port.
This is great $port is currently derived from ssh_port_part, which returns port 22 by default. Switching this to ghe-ssh will prevent some cases where ghe-backup-pages (and some other scripts) try to connect to the wrong port.
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Parent feature
github/ghes-infrastructure#376
This is a work in progress. Further details and tests to come...
/cc @github/backup-utils