bpo-31474: Fix -Wint-in-bool-context warnings #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Sep 14, 2017
Objects/stringlib/formatter.h
Outdated
| @@ -572,7 +572,7 @@ fill_number(STRINGLIB_CHAR *buf, const NumberFieldWidths *spec, | |||
| if (spec->n_sign == 1) { | |||
| *buf++ = spec->sign; | |||
| } | |||
| if (spec->n_prefix) { | |||
| if (spec->n_prefix && prefix) { | |||
There was a problem hiding this comment.
Is it possible that prefix is NULL?
There was a problem hiding this comment.
format_float_internal() calls the fill function with prefix=NULL.
Signed-off-by: Christian Heimes <christian@python.org>
tiran
force-pushed
the
bpo-31474-warnings
branch
from
e160db8
to
14c9588
Compare
tiran
changed the title
|
I'm going to fix the -Wint-in-bool-context warnings first as they are most annoying. Let's figure out the other warnings in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue31474