Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Code of conduct link properly #323

Merged
merged 1 commit into from Sep 5, 2018
Merged

Fixed Code of conduct link properly #323

merged 1 commit into from Sep 5, 2018

Conversation

Copy link
Contributor

@yjaeseok yjaeseok commented Aug 30, 2018

The address specified in the current CODE_OF_CONDUCT.md is https://github.com/nodejs/TSC/blob/master/CODE_OF_CONDUCT.md.

But I think URL link seems to have been changed to admin.

It is my first PR for node-addon-api repo.

@yjaeseok yjaeseok changed the title Fix Code of conduct link properly Fixed Code of conduct link properly Aug 30, 2018
Copy link
Member

@mhdawson mhdawson left a comment

LGTM

Copy link
Member

@NickNaso NickNaso left a comment

LGTM

@yjaeseok
Copy link
Contributor Author

@yjaeseok yjaeseok commented Aug 30, 2018

@mhdawson How could I merge it?
It seems I cannot merge it self ;(

@mhdawson mhdawson merged commit b0ecd38 into nodejs:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants