Skip to content

/ jid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't exit on Enter #29

Open
lodenrogue opened this issue Dec 4, 2016 · 6 comments
Open

Don't exit on Enter #29

lodenrogue opened this issue Dec 4, 2016 · 6 comments
Labels
enhancement

Comments

@lodenrogue
Copy link

@lodenrogue lodenrogue commented Dec 4, 2016 •
edited

Can we change the way the program exits when you hit the 'Enter' button? Maybe make the default exit ctrl-C?

Pressing 'Enter' should select the given auto-complete suggestion.
@simeji
Copy link
Owner

@simeji simeji commented Dec 5, 2016

@lodenrogue Sorry, I can't imagine your situation. Please explain me that detail?
ex. json, query, your os, etc..
@ashishg-qburst
Copy link
Contributor

@ashishg-qburst ashishg-qburst commented Dec 5, 2016

In the demo example

  • .users[1] *Tab* - shows you the result
  • .users[1] *Enter* - exits the program

Its confusing when Enter causes a program to terminate.
@lodenrogue
Copy link
Author

@lodenrogue lodenrogue commented Dec 5, 2016

What ashishg-qburst said
@fiatjaf
Copy link

@fiatjaf fiatjaf commented Dec 6, 2016 •
edited

What do you think Enter should do when there are no suggestions being chosen?
@stevenschlansker
Copy link

@stevenschlansker stevenschlansker commented Dec 6, 2016

Even doing nothing would be preferable to exiting the program. Enter is too common of a "accept my input" command and I already exited jid three times accidentally this way :)
@simeji simeji added the enhancement label Dec 11, 2016
@Larry850806
Copy link

@Larry850806 Larry850806 commented Dec 3, 2018 •
edited

Is anyone working on this? I can help to do this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@stevenschlansker @simeji @fiatjaf @lodenrogue @Larry850806 @ashishg-qburst
You can’t perform that action at this time.