Skip to content

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36266: Add module name in ImportError when DLL not found on Windows #15180

Merged
merged 5 commits into from Aug 17, 2019

Conversation

@shireenrao
Copy link
Contributor

commented Aug 8, 2019 •
edited by bedevere-bot

https://bugs.python.org/issue36266

@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 8, 2019

@bedevere-bot bedevere-bot added the awaiting review label Aug 8, 2019

@blurb-it
📜🤖 Added by blurb_it.
Loading status checks…
11fa5eb
@shireenrao

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Aug 13, 2019

Can a reviewer having a few cycles please take a look at my PR?
@eryksun

eryksun reviewed Aug 13, 2019
View changes

Python/dynload_win.c Outdated Show resolved Hide resolved
@ZackerySpytz

ZackerySpytz reviewed Aug 15, 2019
View changes

Misc/NEWS.d/next/Windows/2019-08-08-18-05-27.bpo-36266.x4eZU3.rst Outdated Show resolved Hide resolved
@shireenrao
remove c:func from NEWS message
Loading status checks…
93912ac

@zooba zooba added the needs backport to 3.8 label Aug 17, 2019

@zooba zooba merged commit 24fe460 into python:master Aug 17, 2019
5 checks passed

5 checks passed

Azure Pipelines PR #20190815.16 succeeded
Details
bedevere/issue-number Issue number 36266 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bedevere-bot bedevere-bot removed the awaiting review label Aug 17, 2019

@miss-islington

This comment has been minimized.

Sign in to view
Copy link

commented Aug 17, 2019

Thanks @shireenrao for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington added a commit to miss-islington/cpython that referenced this pull request Aug 17, 2019

@shireenrao @miss-islington
bpo-36266: Add module name in ImportError when DLL not found on Windo… 
…ws (pythonGH-15180)

(cherry picked from commit 24fe460)

Co-authored-by: shireenrao <shireenrao@gmail.com>
b6fb4fe
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

commented Aug 17, 2019

GH-15324 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Aug 17, 2019

miss-islington added a commit that referenced this pull request Aug 17, 2019

@miss-islington @shireenrao
bpo-36266: Add module name in ImportError when DLL not found on Windo… 
…ws (GH-15180)

(cherry picked from commit 24fe460)

Co-authored-by: shireenrao <shireenrao@gmail.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
786a4e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eryksun eryksun

@ZackerySpytz ZackerySpytz

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
7 participants
@shireenrao @miss-islington @bedevere-bot @eryksun @ZackerySpytz @zooba @the-knights-who-say-ni
You can’t perform that action at this time.