WIP: bpo-35059: _PyThreadState_GET() checks that the GIL is hold #10278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert _PyThreadState_GET() and _PyInterpreterState_GET_UNSAFE() macros to static inline functions, and the functions now check that the GIL is hold. Add _PyThreadState_GET_UNSAFE(): similar to _PyThreadState_GET(), but don't check that the GIL is hold.
|
This can hit performance. Could you open issues for such potentially dangerous changes? |
I used https://bugs.python.org/issue35059 for all changes converting macros to static inline functions. Would you prefer a new dedicated issue for this change? |
|
Right now, I'm not sure that this change is correct. I'm not sure that _PyThreadState_GET() and _PyInterpreterState_GET_UNSAFE() must be called with the GIL hold. |
|
As @serhiy-storchaka wrote, this change looks dangerous. There is a risk of regression. I'm not sure that it's really worth it. I prefer to close my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Convert _PyThreadState_GET() and _PyInterpreterState_GET_UNSAFE()
macros to static inline functions, and the functions now check that
the GIL is hold.
Add _PyThreadState_GET_UNSAFE(): similar to _PyThreadState_GET(), but
don't check that the GIL is hold.
https://bugs.python.org/issue35059