Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFull documentation missing from CloudFront event type #6785
Comments
|
I agree with @trondhindenes . More documentation would be very appreciated. |
richarddd
added a commit
to richarddd/serverless
that referenced
this issue
Jan 22, 2020
) Fixes serverless#7151 Addresses partially serverless#6843 and serverless#6785
|
Very thin indeed. Also, is it currently possible to assign ACM certs for SSL support of distribution? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Description
The documentation for cloudfront is very thin (https://serverless.com/framework/docs/providers/aws/events/cloudfront/). There's a few examples, but there's no complete documentation of all supported params. Since its likely that users have to use a
Resourcesobject to describe the Cloudfront distribution in detail, this event type is potentially quite complex to get right. It would be good of the documentation was a bit richer.For example, there's no mention of the fact that
CustomOriginConfigis a required field if using non-s3 origins.As an example: I notice that in code, the
QueryStringattribute is hard-coded tofalse(serverless/lib/plugins/aws/package/compile/events/cloudFront/index.js
Line 181 in c0ec32b
In short: Make it as easy as possible to get cloudfront/lambda@edge right using serverless - also for non-trivial/real-life apps.