fix(@schematics/angular): don't create e2e script when createApplication is false#16203
Conversation
95901a3 to
9b52f62
Compare
|
Thank you for the contribution. |
|
I also, do agree with @clydin |
|
I agree that it's a valid point raised, I did it because I thought to treat it the same as the minimal flag. I will push a commit later with the changes. |
|
I think the former (removing it from the workspace generation) would be the appropriate path. |
f8e6ca7 to
67d8cd8
Compare
|
Should this be part of the |
|
Hi, @timdeschryver, sorry for taking us long to get back to you about this.
Yes, I think that's the best approach. |
006b85e to
a22106c
Compare
|
Should be ready for another review @alan-agius4 |
…ion is false Bugfix for the ng new --createApplication=false command. Currently, it creates an e2e script in package.json. This change will only add the script when the application is created. Closes angular#13412
a22106c to
9e9ab5b
Compare
|
Hi @timdeschryver, sorry for the delay on this. I rebased the PR and did some changes to get this in! Thanks and sorry once again. |
|
@alan-agius4 no need to say sorry. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bugfix for the
ng new --createApplication=falsecommand.Currently, it creates an
e2escript inpackage.json. This change will only add the script when the application is created.Closes #13412