New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: isolate->Dispose() order consistency #30181

Closed

codebytere wants to merge 1 commit into nodejs:master from codebytere:consistent-dispose

Member

codebytere commented Oct 30, 2019 •

edited

Removes comment from UnregisterIsolate() specifying that Isolate::Dispose() should be called after UnregisterIsolate() since that's no longer the case.

This was originally added to account for issues in V8 but now there should be no relevant tasks running during either call so their order is fungible. However, for consistency's sake, we were calling most of these in the same order (dispose and then unregister) so this also moves a straggling call from node_worker to bring it in line with all others.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines


        src: isolate->Dispose() order consistency

60db970

codebytere requested a review from addaleax

nodejs-github-bot added C++ worker labels

cjihrig approved these changes

addaleax approved these changes

addaleax added the author ready label

devsnek approved these changes

nodejs-github-bot commented Oct 30, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26248/

devnexen approved these changes

Member Author

codebytere commented Nov 1, 2019

Windows Rerun: https://ci.nodejs.org/job/node-test-commit-windows-fanned/30837/

Member Author

codebytere commented Nov 1, 2019

Landed in 312c02d

codebytere closed this

codebytere deleted the codebytere:consistent-dispose branch

codebytere added a commit that referenced this pull request


        src: isolate->Dispose() order consistency

312c02d

PR-URL: #30181
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>

targos added a commit that referenced this pull request


        src: isolate->Dispose() order consistency

cc1cd2b

PR-URL: #30181
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>

targos mentioned this pull request

v13.1.0 release proposal #30262

Merged

targos added a commit that referenced this pull request


        src: isolate->Dispose() order consistency

77861dd

PR-URL: #30181
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>

targos added a commit that referenced this pull request


        src: isolate->Dispose() order consistency

7b3baab

PR-URL: #30181
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>

targos added a commit that referenced this pull request


        src: isolate->Dispose() order consistency

3b6a7c5

PR-URL: #30181
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>

targos mentioned this pull request

v12.13.1 release proposal #30352

Merged

targos added a commit that referenced this pull request


        src: isolate->Dispose() order consistency

ab03c29

PR-URL: #30181
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.