build: update to @bazel/bazel 1.0.0 #33367

gregmagolan · 2019-10-24T04:26:44Z

Also removes build:remote --spawn_strategy=remote from .bazelrc. It seems that with Bazel 1.0.0 setting --incompatible_list_based_execution_strategy_selection=false no longer works around the issue with npm_package that it did when it was added. The error that was originally observed has returned after updating to Bazel 1.0.0:

ERROR: /home/circleci/ng/packages/angular_devkit/build_optimizer/BUILD:66:1: Assembling npm package packages/angular_devkit/build_optimizer/npm_package failed: No usable spawn strategy found for spawn with mnemonic Action. Your --spawn_strategy, --genrule_strategy or --strategy flags are probably too strict. Visit bazelbuild/bazel#7480 for migration advice

This commit removes both —incompatible_list_based_execution_strategy_selection=false as well as build:remote --spawn_strategy=remote which means that Bazel will do the default behavior of picking the first available strategy from the default list, which is remote,worker,sandboxed,local. See bazelbuild/bazel#7480 for more details.

AndrewKushnir · 2019-10-24T22:54:14Z

@gregmagolan could you please rebase this PR and resolve a conflict? Thank you.

Also removes `build:remote --spawn_strategy=remote` from .bazelrc. It seems that with Bazel 1.0.0 setting `--incompatible_list_based_execution_strategy_selection=false` no longer works around the issue with npm_package that it did when it was added. The error that was originally observed has returned after updating to Bazel 1.0.0: ``` ERROR: /home/circleci/ng/packages/angular_devkit/build_optimizer/BUILD:66:1: Assembling npm package packages/angular_devkit/build_optimizer/npm_package failed: No usable spawn strategy found for spawn with mnemonic Action. Your --spawn_strategy, --genrule_strategy or --strategy flags are probably too strict. Visit bazelbuild/bazel#7480 for migration advice ``` This commit removes both `—incompatible_list_based_execution_strategy_selection=false` as well as `build:remote --spawn_strategy=remote` which means that Bazel will do the default behavior of picking the first available strategy from the default list, which is `remote,worker,sandboxed,local`. See bazelbuild/bazel#7480 for more details.

gregmagolan · 2019-10-25T01:35:26Z

@AndrewKushnir Done

josephperrott

Thanks for doing all this update! A few comments, mostly about making sure that we are applying active flags since the .bazelrc.notoolchain file alot of these came from was pretty dated.

josephperrott · 2019-10-25T02:23:36Z

.bazelrc


-# Load default settings for Remote Build Execution.
-import %workspace%/third_party/github.com/bazelbuild/bazel-toolchains/bazelrc/.bazelrc.notoolchain
+# Starting with Bazel 0.27.0 strategies do not need to be explicitly


I think we should be fine to not comment on why we no longer have something in the code. As this is now the standard, it will become more obsolete as a comment as time goes on. Unless I am misunderstanding the situation and issue that you reference in this comment.

👍 You have it correct and it will become obsolete. The comment comes from https://github.com/bazelbuild/bazel-toolchains/blob/master/bazelrc/bazel-1.0.0.bazelrc#L45 but in this context (which is not versioned) I think you're right that it is better to leave it out as it will become dated.

josephperrott · 2019-10-25T02:24:28Z

.bazelrc

-import %workspace%/third_party/github.com/bazelbuild/bazel-toolchains/bazelrc/.bazelrc.notoolchain
+# Starting with Bazel 0.27.0 strategies do not need to be explicitly
+# defined. See https://github.com/bazelbuild/bazel/issues/7480
+build:remote --define=EXECUTOR=remote


We should note that this --define=EXECUTOR=remote will be able to be removed once https://github.com/bazelbuild/bazel/issues/7254 is fixed.

josephperrott · 2019-10-25T02:25:16Z

.bazelrc

+build:remote --remote_executor=remotebuildexecution.googleapis.com
+
+# Enable encryption.
+build:remote --tls_enabled=true


We should be able to remove this as --tls_enabled is a noop: https://docs.bazel.build/versions/1.0.0/command-line-reference.html#flag--tls_enabled

josephperrott · 2019-10-25T02:28:05Z

packages/bazel/package.bzl

-        strip_prefix = "bazel-toolchains-0.28.2",
-        url = "https://github.com/bazelbuild/bazel-toolchains/archive/0.28.2.tar.gz",
+        sha256 = "0b36eef8a66f39c8dbae88e522d5bbbef49d5e66e834a982402c79962281be10",
+        strip_prefix = "bazel-toolchains-1.0.1",


Should this be toolchains 1.0.0 since we are going to bazel 1.0.0?

Its sometimes off by a patch version. https://github.com/bazelbuild/bazel-toolchains/releases/tag/1.0.1 is still for Bazel 1.0.0

josephperrott · 2019-10-25T02:29:37Z

.bazelrc

+build:remote --define=EXECUTOR=remote
+
+# Enable remote execution so actions are performed on the remote systems.
+build:remote --remote_executor=remotebuildexecution.googleapis.com


Can we move this remote_executor flag to line 134 to be located with the --remote_cache and --remote_instance_name flags?

josephperrott · 2019-10-25T02:32:37Z

.bazelrc

+build:remote --tls_enabled=true
+
+# Set a higher timeout value, just in case.
+build:remote --remote_timeout=3600


I know this is what we had previously coming from the our /third_party/.. code, but 3600 seconds seems excessive. If our remote builds either for execution and/or cache hits are taking an hour, I would rather fail earlier.

It seems to me that this makes more sense to be set as something like 600 (10 minutes) which is probably still longer than we are truly okay with it taking.

josephperrott · 2019-10-25T02:34:02Z

.bazelrc

+# Enable authentication. This will pick up application default credentials by
+# default. You can use --auth_credentials=some_file.json to use a service
+# account credential instead.
+build:remote --auth_enabled=true


This can be removed as it is actually already enabled with --google_default_credentials. auth_enabled is the old name of the flag: https://github.com/bazelbuild/bazel/blob/d2de8ee925710b757a637bc8ad1036546a030756/src/main/java/com/google/devtools/build/lib/authandtls/AuthAndTLSOptions.java#L30

josephperrott

Thanks for doing all this update! A few comments, mostly about making sure that we are applying active flags since the .bazelrc.notoolchain file alot of these came from was pretty dated.

gregmagolan · 2019-10-25T02:44:45Z

Thanks for the detailed review @josephperrott! Updating...

josephperrott

LGTM

PR Close #33367

This reverts commit aa36b55. PR Close #33407

This reverts commit 348615b. PR Close #33407

gregmagolan · 2019-10-28T14:44:42Z

Note: this was reverted because of a Windows CI failure with Bazel 1.0.0

https://app.circleci.com/jobs/github/angular/angular/501770:

---8<---8<--- Start of log, file at C:/users/circleci/_bazel_circleci/u4uoan2j/bazel-workers/worker-2-TypeScriptCompile.log ---8<---8<---
Error: Cannot find module 'npm/node_modules/@bazel/typescript/internal/tsc_wrapped/tsc_wrapped.js'. Please verify that the package.json has a valid "main" entry
    at Function.module.constructor._resolveFilename (C:\users\circleci\_bazel_circleci\u4uoan2j\execroot\angular\bazel-out\host\bin\external\npm\@bazel\typescript\bin\tsc_wrapped_loader.js:485:17)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Object.<anonymous> (C:\users\circleci\_bazel_circleci\u4uoan2j\execroot\angular\bazel-out\host\bin\external\npm\@bazel\typescript\bin\tsc_wrapped_loader.js:524:24)
    at Module._compile (internal/modules/cjs/loader.js:776:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:787:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:829:12)
    at startup (internal/bootstrap/node.js:283:19)
---8<---8<--- End of log ---8<---8<---

Investigating...

gregmagolan · 2019-10-29T21:43:49Z

NOTE: I attempted to update to @bazel/bazel 1.1.0 in this PR but it created another issue in CI with docker access permissions:

ERROR: An error occurred during the fetch of repository 'rbe_ubuntu1604_angular':
   Traceback (most recent call last):
    File "/home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/bazel_toolchains/rules/rbe_repo.bzl", line 449
        validate_host(ctx)
    File "/home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/bazel_toolchains/rules/rbe_repo/util.bzl", line 161, in validate_host
        fail(<2 more arguments>)
attribute Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
: Cannot run rbe_autoconfig as running '%s ps' returned a non 0 exit code, please check you have permissions to run docker. Error message: /usr/bin/docker
ERROR: /home/circleci/ng/tools/BUILD.bazel:16:1: //tools:rbe_ubuntu1604-angular depends on @rbe_ubuntu1604_angular//config:platform in repository @rbe_ubuntu1604_angular which failed to fetch. no such package '@rbe_ubuntu1604_angular//config': Traceback (most recent call last):
    File "/home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/bazel_toolchains/rules/rbe_repo.bzl", line 449
        validate_host(ctx)
    File "/home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/bazel_toolchains/rules/rbe_repo/util.bzl", line 161, in validate_host
        fail(<2 more arguments>)
attribute Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
: Cannot run rbe_autoconfig as running '%s ps' returned a non 0 exit code, please check you have permissions to run docker. Error message: /usr/bin/docker
ERROR: While resolving toolchains for target //packages/platform-webworker:npm_package: Target //tools:rbe_ubuntu1604-angular was referenced as a platform, but does not provide PlatformInfo
ERROR: Analysis of target '//packages/platform-webworker:npm_package' failed; build aborted: Analysis failed

Looks like due to a change in rbe_autoconfig with bazel_tools 1.1.0. Will leave that battle for another day.

Also removes `build:remote --spawn_strategy=remote` from .bazelrc. It seems that with Bazel 1.0.0 setting `--incompatible_list_based_execution_strategy_selection=false` no longer works around the issue with npm_package that it did when it was added. The error that was originally observed has returned after updating to Bazel 1.0.0: ``` ERROR: /home/circleci/ng/packages/angular_devkit/build_optimizer/BUILD:66:1: Assembling npm package packages/angular_devkit/build_optimizer/npm_package failed: No usable spawn strategy found for spawn with mnemonic Action. Your --spawn_strategy, --genrule_strategy or --strategy flags are probably too strict. Visit bazelbuild/bazel#7480 for migration advice ``` This commit removes both `—incompatible_list_based_execution_strategy_selection=false` as well as `build:remote --spawn_strategy=remote` which means that Bazel will do the default behavior of picking the first available strategy from the default list, which is `remote,worker,sandboxed,local`. See bazelbuild/bazel#7480 for more details. Not updating to Bazel 1.1.0 yet due to a docker permissions CI issue that was observed on the angular repo that is unresolved. See #33367 (comment). PR Close #33476

Not updating to Bazel 1.1.0 yet due to a docker permissions CI issue that was observed on the angular repo that is unresolved. See #33367 (comment). PR Close #33476

angular-automatic-lock-bot · 2019-11-29T16:11:17Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Oct 24, 2019

gregmagolan changed the title ~~build: update to @bazel/bazel 1.0.0~~ build: update to @bazel/bazel 1.1.0 Oct 24, 2019

gregmagolan added target: major This PR is targeted for the next major release area: bazel Issues related to the published `@angular/bazel` build rules labels Oct 24, 2019

ngbot bot added this to the needsTriage milestone Oct 24, 2019

gregmagolan changed the title ~~build: update to @bazel/bazel 1.1.0~~ build: update to @bazel/bazel 1.0.0 Oct 24, 2019

gregmagolan marked this pull request as ready for review October 24, 2019 07:34

gregmagolan requested review from a team and alexeagle October 24, 2019 07:35

alexeagle approved these changes Oct 24, 2019

View reviewed changes

gregmagolan added the action: merge The PR is ready for merge by the caretaker label Oct 24, 2019

gregmagolan mentioned this pull request Oct 24, 2019

chore: update bazel-toolchains bazel-contrib/rules_nodejs#1302

Merged

AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 24, 2019

gregmagolan removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 25, 2019

josephperrott reviewed Oct 25, 2019

View reviewed changes

josephperrott requested changes Oct 25, 2019

View reviewed changes

build: address review comments in .bazelrc

abb73e4

gregmagolan requested a review from josephperrott October 25, 2019 04:51

josephperrott approved these changes Oct 25, 2019

View reviewed changes

alexeagle added the action: merge The PR is ready for merge by the caretaker label Oct 25, 2019

AndrewKushnir closed this in 348615b Oct 25, 2019

AndrewKushnir pushed a commit that referenced this pull request Oct 25, 2019

build: address review comments in .bazelrc (#33367)

aa36b55

PR Close #33367

AndrewKushnir pushed a commit that referenced this pull request Oct 25, 2019

revert: build: address review comments in .bazelrc (#33367) (#33407)

f085fd5

This reverts commit aa36b55. PR Close #33407

AndrewKushnir pushed a commit that referenced this pull request Oct 25, 2019

revert: build: update to @bazel/bazel 1.0.0 (#33367) (#33407)

e4e8dbd

This reverts commit 348615b. PR Close #33407

gregmagolan mentioned this pull request Oct 28, 2019

ts_library does not work with Bazel 1.0.0+ on Windows bazel-contrib/rules_nodejs#1307

Closed

gregmagolan mentioned this pull request Oct 29, 2019

build: update to @bazel/bazel 1.0.0 #33476

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 29, 2019

build: update to @bazel/bazel 1.0.0 #33367

build: update to @bazel/bazel 1.0.0 #33367

Uh oh!

Conversation

gregmagolan commented Oct 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndrewKushnir commented Oct 24, 2019

Uh oh!

gregmagolan commented Oct 25, 2019

Uh oh!

josephperrott left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

josephperrott left a comment

Choose a reason for hiding this comment

Uh oh!

gregmagolan commented Oct 25, 2019

Uh oh!

josephperrott left a comment

Choose a reason for hiding this comment

Uh oh!

gregmagolan commented Oct 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gregmagolan commented Oct 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

angular-automatic-lock-bot bot commented Nov 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gregmagolan commented Oct 24, 2019 •

edited

Loading

gregmagolan commented Oct 28, 2019 •

edited

Loading

gregmagolan commented Oct 29, 2019 •

edited

Loading