Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing parenthesis #31041

Closed
wants to merge 1 commit into from
Closed

docs: add missing parenthesis #31041

wants to merge 1 commit into from

Conversation

atefBB
Copy link
Contributor

@atefBB atefBB commented Jun 14, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@atefBB atefBB requested a review from as a code owner Jun 14, 2019
@ngbot ngbot bot added this to the Backlog milestone Jun 14, 2019
@ngbot ngbot bot added this to the Backlog milestone Jun 14, 2019
@kapunahelewong kapunahelewong changed the title Add missing parenthesis docs: add missing parenthesis Jun 14, 2019
Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Great catch, @atefBB! Only one tiny thing, could you amend your commit message as I've edited the PR title?

docs: add missing parenthesis

The command if you need it: git commit --amend

Please tag me when you're done. Thanks!

@atefBB
Copy link
Contributor Author

@atefBB atefBB commented Jun 14, 2019

@kapunahelewong I think I can't because I havenot fork your repo to do this change !
Did you have any ideas how to do so?

@kapunahelewong
Copy link
Contributor

@kapunahelewong kapunahelewong commented Jun 14, 2019

Hi @atefBB, you shouldn't have to fork anything else. If you're using the command line for working with git, checkout your branch if needed and do the following:

  1. git commit --amend
  2. An editor (whichever is your default) will open. Change the name of the commit message, save, and close according to the editor.
  3. git push (you might have to do git push -f)

If you're using a GUI GitHub client, your steps will be different, but the goal is the same. Does this help?

@atefBB
Copy link
Contributor Author

@atefBB atefBB commented Jun 14, 2019

@kapunahelewong You mean fw-dev-infra by your branch?

@kapunahelewong
Copy link
Contributor

@kapunahelewong kapunahelewong commented Jun 17, 2019

@atefBB, it looks like your branch is: patch-1

Here it is: https://github.com/atefBB/angular/tree/patch-1

Just be sure you're on that branch locally when you amend your commit message.

@atefBB
Copy link
Contributor Author

@atefBB atefBB commented Jun 18, 2019

@kapunahelewong DONE !
Thank you for help.

@kapunahelewong
Copy link
Contributor

@kapunahelewong kapunahelewong commented Jun 18, 2019

Great @atefBB! 😊Now, to get the failing tests to pass, first start by rebasing. Your change shouldn't have caused those failures, so the first step is to make sure you're all updated when failures like that happen. Are you ok rebasing? If the commands would be helpful:

  1. On your patch-1 branch, do git rebase upstream/master.
  2. Then git push. (You might need git push -f to force push)

That will update your branch and re-trigger the tests. Hopefully they will all pass with the latest from master. Good luck!

@petebacondarwin petebacondarwin removed request for and IgorMinar Oct 7, 2019
@petebacondarwin
Copy link
Member

@petebacondarwin petebacondarwin commented Oct 7, 2019

I have rebased this PR on top of master so it is only one commit now. Thanks for your patience @atefBB and @kapunahelewong

@petebacondarwin
Copy link
Member

@petebacondarwin petebacondarwin commented Oct 7, 2019

Caretaker (merge-assistance): this is a one character documentation change so I don't think it can be merged without tacit approval from @angular/dev-infra-framework .

@atefBB
Copy link
Contributor Author

@atefBB atefBB commented Oct 7, 2019

@petebacondarwin Thank you, Sorry for my dirty work !

alxhub added a commit that referenced this issue Oct 7, 2019
@atefBB atefBB deleted the patch-1 branch Oct 8, 2019
ODAVING added a commit to ODAVING/angular that referenced this issue Oct 18, 2019
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Nov 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants