New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add missing parenthesis #31041
Conversation
Great catch, @atefBB! Only one tiny thing, could you amend your commit message as I've edited the PR title?
docs: add missing parenthesis
The command if you need it: git commit --amend
Please tag me when you're done. Thanks!
|
@kapunahelewong I think I can't because I havenot |
|
Hi @atefBB, you shouldn't have to fork anything else. If you're using the command line for working with git, checkout your branch if needed and do the following:
If you're using a GUI GitHub client, your steps will be different, but the goal is the same. Does this help? |
|
@kapunahelewong You mean |
|
@atefBB, it looks like your branch is: Here it is: https://github.com/atefBB/angular/tree/patch-1 Just be sure you're on that branch locally when you amend your commit message. |
|
@kapunahelewong DONE ! |
|
Great @atefBB!
That will update your branch and re-trigger the tests. Hopefully they will all pass with the latest from |
|
I have rebased this PR on top of master so it is only one commit now. Thanks for your patience @atefBB and @kapunahelewong |
|
Caretaker (merge-assistance): this is a one character documentation change so I don't think it can be merged without tacit approval from @angular/dev-infra-framework . |
|
@petebacondarwin Thank you, Sorry for my |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information