Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Build instructions for Docker 19.03 #33346

Closed
dmitryr117 opened this issue Oct 14, 2019 · 3 comments · Fixed by #33367
Closed

Update Build instructions for Docker 19.03 #33346

dmitryr117 opened this issue Oct 14, 2019 · 3 comments · Fixed by #33367
Assignees
@lamberta
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower type:build/install Build and install issues type:docs-bug Document issues

Comments

@dmitryr117
Copy link

dmitryr117 commented Oct 14, 2019 •
edited
Loading

Description of issue (what needs changing):

Docker Build from Source documentation seems to be out of date for docker 19.03.
For example there is no --runtime=nvidia flag available any more.
@dmitryr117 dmitryr117 added the type:docs-bug Document issues label Oct 14, 2019
@blairhan
Copy link
Contributor

yes. as stated here the command needs to be changed.

docker < 19.03:
docker run --runtime=nvidia -it -w /tensorflow -v $PWD:/mnt -e HOST_PERMS="$(id -u):$(id -g)"
tensorflow/tensorflow:devel-gpu-py3 bash

docker >= 19.03:
docker run --gpus all -it -w /tensorflow -v $PWD:/mnt -e HOST_PERMS="$(id -u):$(id -g)"
tensorflow/tensorflow:devel-gpu-py3 bash

@yongtang yongtang mentioned this issue Oct 15, 2019
Merged
@yongtang
Copy link
Member

Added PR #33367 with docs updated.

@ravikyram ravikyram self-assigned this Oct 15, 2019
@ravikyram ravikyram added the type:build/install Build and install issues label Oct 15, 2019
@jvishnuvardhan jvishnuvardhan added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Nov 15, 2019
@tensorflow-bot
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lamberta lamberta

Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower type:build/install Build and install issues type:docs-bug Document issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upate dockerfiles/README.md for usages of --gpus all yongtang/tensorflow
6 participants
@lamberta @dmitryr117 @yongtang @blairhan @jvishnuvardhan @ravikyram