doc: set module version 72 to node 12 #29877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearly state the modules version 72 is official node 12, similar as it is done for other major node versions.
richardlau
approved these changes
Oct 7, 2019
|
I'm hesitant to add more work for our releasers, but should this step be added to the release process for majors? |
BethGriggs
approved these changes
Oct 7, 2019
gengjiawen
approved these changes
Oct 8, 2019
devnexen
approved these changes
Oct 8, 2019
MylesBorins
approved these changes
Oct 8, 2019
BridgeAR
approved these changes
Oct 9, 2019
mmarchini
approved these changes
Oct 10, 2019
|
Landed in 8b9a578 |
mmarchini
added a commit
that referenced
this issue
Oct 10, 2019
Clearly state the modules version 72 is official node 12, similar as it is done for other major node versions. PR-URL: #29877 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
added a commit
that referenced
this issue
Oct 14, 2019
Clearly state the modules version 72 is official node 12, similar as it is done for other major node versions. PR-URL: #29877 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Clearly state the modules version 72 is official node 12, similar as it
is done for other major node versions.
Checklist