cli: rename --loader to --experimental-loader #29752
Conversation
|
Is the intention to go back to using |
|
@addaleax the intention is to unflag modules while leaving loader as experimental for the time being, unflagging only after the development work to bring loaders to stable. Whether this could happen for 12 or only in 13 is another question too, and one we were hoping to get some feedback from on the releases group side. |
|
@guybedford Okay, then replace “once ESM is no longer experimental” with “once ESM loaders are no longer experimental” :) |
|
Using The check is failing because I use |
I would ignore that, tbh. |
Renames the `--loader` cli argument to `--experimental-loader`. This is to clearly indicate the esm loader feature as experimental even after esm is no longer experimental. Also minorly alters the `--experimental-loader` docs to say that the passed loader can be an esm module. Refs: nodejs/modules#351 (comment)
reasonablytall
force-pushed
the
experimental-loader-flag
branch
from
655cdf9
to
b5b6bb0
Compare
|
Landed in 15fb02a |
Renames the `--loader` cli argument to `--experimental-loader`. This is to clearly indicate the esm loader feature as experimental even after esm is no longer experimental. Also minorly alters the `--experimental-loader` docs to say that the passed loader can be an esm module. Refs: nodejs/modules#351 (comment) PR-URL: #29752 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Renames the `--loader` cli argument to `--experimental-loader`. This is to clearly indicate the esm loader feature as experimental even after esm is no longer experimental. Also minorly alters the `--experimental-loader` docs to say that the passed loader can be an esm module. Refs: nodejs/modules#351 (comment) PR-URL: #29752 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Renames the
--loadercli argument to--experimental-loader. This isto clearly indicate the esm loader feature as experimental even after
esm is no longer experimental.
Also minorly alters the
--experimental-loaderdocs to say that thepassed loader can be an esm module.
An alternative to this PR is to leave things unchanged and continue to use
--experimental-modulesto allow the use of--loader, even after ECMAScript modules are unflagged. This would reduce the number of different argument schemes a hypothetical script that wraps node would need to try, as discussed here: nodejs/modules#351 (comment)Refs: nodejs/modules#351 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes