Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: add oaepLabel option #29489

Closed
wants to merge 2 commits into from
+91 −49

Conversation

@tniessen
Copy link
Member

commented Sep 8, 2019

The label acts as the "L" input to the RSA-OAEP algorithm.

cc @nodejs/crypto @nodejs/security

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@tniessen
crypto: add oaepLabel option 
The label acts as the "L" input to the RSA-OAEP algorithm.
Loading status checks…
9410f35

@tniessen tniessen added crypto semver-minor labels Sep 8, 2019

@nodejs-github-bot nodejs-github-bot added C++ lib / src labels Sep 8, 2019

@devnexen
devnexen approved these changes Sep 8, 2019
View changes
Copy link
Contributor

left a comment

LGTM
@bnoordhuis
bnoordhuis approved these changes Sep 8, 2019
View changes
src/node_crypto.cc Outdated Show resolved Hide resolved

@tniessen tniessen force-pushed the tniessen:crypto-add-oaep-label branch from 7f37685 to 9410f35 Sep 8, 2019

@tniessen
crypto: fix OpenSSL return code handling
Loading status checks…
22c3bfd
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
Copy link

commented Sep 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25398/
@JungMinu
JungMinu approved these changes Sep 9, 2019
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 9, 2019 •
edited by tniessen

CI: https://ci.nodejs.org/job/node-test-pull-request/25408/ (✔️)
@jasnell
jasnell approved these changes Sep 11, 2019
View changes
tniessen added a commit that referenced this pull request Sep 13, 2019
@tniessen
crypto: add oaepLabel option 
The label acts as the "L" input to the RSA-OAEP algorithm.

PR-URL: #29489
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
tniessen Tobias Nießen
GPG key ID: 718207F8FD156B70 Learn about signing commits
b644466
tniessen added a commit that referenced this pull request Sep 13, 2019
@tniessen
crypto: fix OpenSSL return code handling 
PR-URL: #29489
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
tniessen Tobias Nießen
GPG key ID: 718207F8FD156B70 Learn about signing commits
Loading status checks…
3675f40
@tniessen

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Sep 13, 2019

Landed in dff22dd...3675f40.

@tniessen tniessen closed this Sep 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis

@jasnell jasnell

@devnexen devnexen

@JungMinu JungMinu

Assignees
No one assigned
Labels
C++ crypto lib / src semver-minor
Projects
None yet
Milestone
No milestone
6 participants
@tniessen @nodejs-github-bot @bnoordhuis @jasnell @devnexen @JungMinu
You can’t perform that action at this time.