Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uphttp2: no crash on stream listener removal w/ destroyed session #29459
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Landed in e585caa |
Trott
added a commit
that referenced
this pull request
Sep 8, 2019
JeniaBR
added a commit
to JeniaBR/node
that referenced
this pull request
Sep 11, 2019
Do not crash when the session is no longer available. Fixes: nodejs#29457 PR-URL: nodejs#29459 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
JeniaBR
added a commit
to JeniaBR/node
that referenced
this pull request
Sep 11, 2019
Do not crash when the session is no longer available. Fixes: nodejs#29457 PR-URL: nodejs#29459 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Sep 19, 2019
Do not crash when the session is no longer available. Fixes: nodejs#29457 PR-URL: nodejs#29459 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Sep 19, 2019
Do not crash when the session is no longer available. Fixes: nodejs#29457 PR-URL: nodejs#29459 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Sep 19, 2019
Merged
BethGriggs
added a commit
that referenced
this pull request
Sep 25, 2019
Do not crash when the session is no longer available. Fixes: #29457 PR-URL: #29459 Backport-PR-URL: #29618 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Sep 25, 2019
This was referenced Sep 26, 2019
BethGriggs
added a commit
that referenced
this pull request
Oct 1, 2019
Do not crash when the session is no longer available. Fixes: #29457 PR-URL: #29459 Backport-PR-URL: #29619 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
addaleax commentedSep 5, 2019
Do not crash when the session is no longer available.
Fixes: #29457
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes