Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api: mark version 5 N-APIs as stable #29401

Closed
wants to merge 1 commit into from

Conversation

@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Sep 2, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@gabrielschulhof gabrielschulhof requested review from addaleax and mhdawson Sep 2, 2019
@gabrielschulhof gabrielschulhof referenced this pull request Sep 2, 2019
Closed
@bnoordhuis
bnoordhuis approved these changes Sep 2, 2019
View changes
Copy link
Member

bnoordhuis left a comment

LGTM but you might want to update the documentation for napi_get_date_value() to specify whether it does or doesn't include leap seconds.

Since it's UNIX time and presumably the equivalent of Date.p.valueOf() I'm guessing it doesn't but there's really no way to tell for a casual reader.
@cjihrig
cjihrig approved these changes Sep 2, 2019
View changes
@jasnell
jasnell approved these changes Sep 3, 2019
View changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Sep 4, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25352/
@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented Sep 4, 2019

@bnoordhuis I'm actually not sure whether it does or does not account for leap seconds. napi_get_date_value() merely calls v8::Date::ValueOf() which is documented as a specialization of v8::Value::NumberValue without mention of its (lack of) accounting for leap seconds.
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Sep 4, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25354/
@gabrielschulhof
n-api: mark version 5 N-APIs as stable
Loading status checks…
102eecc
@gabrielschulhof gabrielschulhof force-pushed the gabrielschulhof:mark-apis-as-stable branch from 3e1c354 to 102eecc Sep 4, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Sep 4, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25355/
@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented Sep 4, 2019

Rebased. Hoping this'll fix Travis.
@bnoordhuis

This comment has been minimized.

Sign in to view
Copy link
Member

bnoordhuis commented Sep 4, 2019

I'm actually not sure whether it does or does not account for leap seconds.

From https://tc39.es/ecma262/#sec-time-values-and-time-range:

Time in ECMAScript does not observe leap seconds; they are ignored.
@gabrielschulhof gabrielschulhof referenced this pull request Sep 4, 2019
Closed
@mhdawson
mhdawson approved these changes Sep 4, 2019
View changes
Copy link
Member

mhdawson left a comment

LGTM
gabrielschulhof added a commit that referenced this pull request Sep 5, 2019
@gabrielschulhof
n-api: mark version 5 N-APIs as stable
Loading status checks…
4e5bb25 
PR-URL: #29401
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gabrielschulhof commented Sep 5, 2019

Landed in 4e5bb25.
gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Sep 5, 2019
@gabrielschulhof
n-api: mark version 5 N-APIs as stable
fc29c08 
PR-URL: nodejs#29401
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof gabrielschulhof referenced this pull request Sep 5, 2019
Closed
4 of 4 tasks complete
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@gabrielschulhof @JeniaBR
n-api: mark version 5 N-APIs as stable
564839a 
PR-URL: nodejs#29401
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@gabrielschulhof @JeniaBR
n-api: mark version 5 N-APIs as stable
e5d10f6 
PR-URL: nodejs#29401
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof gabrielschulhof referenced this pull request Sep 20, 2019
Closed
3 of 3 tasks complete
targos added a commit that referenced this pull request Sep 20, 2019
@gabrielschulhof @targos
n-api: mark version 5 N-APIs as stable
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
50d7c39 
PR-URL: #29401
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BridgeAR BridgeAR referenced this pull request Sep 24, 2019
Merged
This was referenced Sep 25, 2019
Closed
Closed
This was referenced Sep 26, 2019
Closed
Closed
Closed
Closed
BethGriggs added a commit that referenced this pull request Oct 1, 2019
@gabrielschulhof @BethGriggs
n-api: mark version 5 N-APIs as stable
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
c74c6a5 
PR-URL: #29401
Backport-PR-URL: #29458
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BethGriggs BethGriggs referenced this pull request Oct 7, 2019
Merged
BethGriggs added a commit that referenced this pull request Oct 18, 2019
@BethGriggs
2019-10-22, Version 10.17.0 'Dubnium' (LTS)
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
44ef30e 
Notable changes:

- **deps**: upgrade openssl sources to 1.1.1d (Sam Roberts)
  [#29921](#29921)
- **dns**: remove dns.promises experimental warning (cjihrig)
  [#26592](#26592)
- **fs**: remove experimental warning for fs.promises (Anna Henningsen)
  [#26581](#26581)
- **n-api**: mark version 5 N-APIs as stable (Gabriel Schulhof)
  [#29401](#29401)
- **stream**: make Symbol.asyncIterator support stable (Matteo Collina)
  [#26989](#26989)

PR-URL: #29875
BethGriggs added a commit that referenced this pull request Oct 18, 2019
@BethGriggs
2019-10-22, Version 10.17.0 'Dubnium' (LTS)
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
21604db 
Notable changes:

- **deps**: upgrade openssl sources to 1.1.1d (Sam Roberts)
  [#29921](#29921)
- **dns**: remove dns.promises experimental warning (cjihrig)
  [#26592](#26592)
- **fs**: remove experimental warning for fs.promises (Anna Henningsen)
  [#26581](#26581)
- **n-api**: mark version 5 N-APIs as stable (Gabriel Schulhof)
  [#29401](#29401)
- **stream**: make Symbol.asyncIterator support stable (Matteo Collina)
  [#26989](#26989)

PR-URL: #29875
BethGriggs added a commit that referenced this pull request Oct 18, 2019
@BethGriggs
2019-10-22, Version 10.17.0 'Dubnium' (LTS)
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
db9181e 
Notable changes:

- **deps**: upgrade openssl sources to 1.1.1d (Sam Roberts)
  [#29921](#29921)
- **dns**: remove dns.promises experimental warning (cjihrig)
  [#26592](#26592)
- **fs**: remove experimental warning for fs.promises (Anna Henningsen)
  [#26581](#26581)
- **n-api**: mark version 5 N-APIs as stable (Gabriel Schulhof)
  [#29401](#29401)
- **stream**: make Symbol.asyncIterator support stable (Matteo Collina)
  [#26989](#26989)

PR-URL: #29875
BethGriggs added a commit that referenced this pull request Oct 19, 2019
@BethGriggs
2019-10-22, Version 10.17.0 'Dubnium' (LTS)
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
c3e596f 
Notable changes:

- **deps**: update npm to 6.11.3 (claudiahdz)
  [#29430](#29430)
- **deps**: upgrade openssl sources to 1.1.1d (Sam Roberts)
  [#29921](#29921)
- **dns**: remove dns.promises experimental warning (cjihrig)
  [#26592](#26592)
- **fs**: remove experimental warning for fs.promises (Anna Henningsen)
  [#26581](#26581)
- **n-api**: mark version 5 N-APIs as stable (Gabriel Schulhof)
  [#29401](#29401)
- **stream**: make Symbol.asyncIterator support stable (Matteo Collina)
  [#26989](#26989)

PR-URL: #29875
BethGriggs added a commit that referenced this pull request Oct 21, 2019
@BethGriggs
2019-10-22, Version 10.17.0 'Dubnium' (LTS)
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
ae884d3 
Notable changes:

- **deps**: update npm to 6.11.3 (claudiahdz)
  [#29430](#29430)
- **deps**: upgrade openssl sources to 1.1.1d (Sam Roberts)
  [#29921](#29921)
- **dns**: remove dns.promises experimental warning (cjihrig)
  [#26592](#26592)
- **fs**: remove experimental warning for fs.promises (Anna Henningsen)
  [#26581](#26581)
- **n-api**: mark version 5 N-APIs as stable (Gabriel Schulhof)
  [#29401](#29401)
- **stream**: make Symbol.asyncIterator support stable (Matteo Collina)
  [#26989](#26989)

PR-URL: #29875
BethGriggs added a commit that referenced this pull request Oct 22, 2019
@BethGriggs
2019-10-22, Version 10.17.0 'Dubnium' (LTS)
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
864c7ff 
Notable changes:

- crypto:
  - add support for chacha20-poly1305 for AEAD (chux0519)
    #24081
  - increase maxmem range from 32 to 53 bits (Tobias Nießen)
    #28799
- deps:
  - update npm to 6.11.3 (claudiahdz)
    #29430
  - upgrade openssl sources to 1.1.1d (Sam Roberts)
    #29921
- dns:
  - remove dns.promises experimental warning (cjihrig)
    #26592
- fs:
  - remove experimental warning for fs.promises (Anna Henningsen)
    #26581
- http:
  - makes response.writeHead return the response (Mark S. Everitt)
    #25974
- http2:
  - makes response.writeHead return the response (Mark S. Everitt)
    #25974
- n-api:
  - make func argument of napi\_create\_threadsafe\_function optional
    (legendecas) #27791
  - mark version 5 N-APIs as stable (Gabriel Schulhof)
    #29401
  - implement date object (Jarrod Connolly)
    #25917
- process:
  - add --unhandled-rejections flag (Ruben Bridgewater)
    #26599
- stream:
  - implement Readable.from async iterator utility (Guy Bedford)
    #27660
  - make Symbol.asyncIterator support stable (Matteo Collina)
    #26989

PR-URL: #29875
BethGriggs added a commit that referenced this pull request Oct 22, 2019
@BethGriggs
2019-10-22, Version 10.17.0 'Dubnium' (LTS)
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
0dc0160 
Notable changes:

- crypto:
  - add support for chacha20-poly1305 for AEAD (chux0519)
    #24081
  - increase maxmem range from 32 to 53 bits (Tobias Nießen)
    #28799
- deps:
  - update npm to 6.11.3 (claudiahdz)
    #29430
  - upgrade openssl sources to 1.1.1d (Sam Roberts)
    #29921
- dns:
  - remove dns.promises experimental warning (cjihrig)
    #26592
- fs:
  - remove experimental warning for fs.promises (Anna Henningsen)
    #26581
- http:
  - makes response.writeHead return the response (Mark S. Everitt)
    #25974
- http2:
  - makes response.writeHead return the response (Mark S. Everitt)
    #25974
- n-api:
  - make func argument of napi\_create\_threadsafe\_function optional
    (legendecas)
    #27791
  - mark version 5 N-APIs as stable (Gabriel Schulhof)
    #29401
  - implement date object (Jarrod Connolly)
    #25917
- process:
  - add --unhandled-rejections flag (Ruben Bridgewater)
    #26599
- stream:
  - implement Readable.from async iterator utility (Guy Bedford)
    #27660
  - make Symbol.asyncIterator support stable (Matteo Collina)
    #26989

PR-URL: #29875
BethGriggs added a commit that referenced this pull request Oct 22, 2019
@BethGriggs
2019-10-22, Version 10.17.0 'Dubnium' (LTS)
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
5dae3ef 
Notable changes:

* crypto:
  * add support for chacha20-poly1305 for AEAD (chux0519)
    #24081
  * increase maxmem range from 32 to 53 bits (Tobias Nießen)
    #28799
* deps:
  * update npm to 6.11.3 (claudiahdz)
    #29430
  * upgrade openssl sources to 1.1.1d (Sam Roberts)
    #29921
* dns:
  * remove dns.promises experimental warning (cjihrig)
    #26592
* fs:
  * remove experimental warning for fs.promises (Anna Henningsen)
    #26581
* http:
  * makes response.writeHead return the response (Mark S. Everitt)
    #25974
* http2:
  * makes response.writeHead return the response (Mark S. Everitt)
    #25974
* n-api:
  * make func argument of napi\_create\_threadsafe\_function optional
    (legendecas)
    #27791
  * mark version 5 N-APIs as stable (Gabriel Schulhof)
    #29401
  * implement date object (Jarrod Connolly)
    #25917
* process:
  * add --unhandled-rejections flag (Ruben Bridgewater)
    #26599
* stream:
  * implement Readable.from async iterator utility (Guy Bedford)
    #27660
  * make Symbol.asyncIterator support stable (Matteo Collina)
    #26989

PR-URL: #29875
BethGriggs added a commit that referenced this pull request Oct 22, 2019
@BethGriggs
2019-10-22, Version 10.17.0 'Dubnium' (LTS)
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
afbbcb0 
Notable changes:

* crypto:
  * add support for chacha20-poly1305 for AEAD (chux0519)
    #24081
  * increase maxmem range from 32 to 53 bits (Tobias Nießen)
    #28799
* deps:
  * update npm to 6.11.3 (claudiahdz)
    #29430
  * upgrade openssl sources to 1.1.1d (Sam Roberts)
    #29921
* dns:
  * remove dns.promises experimental warning (cjihrig)
    #26592
* fs:
  * remove experimental warning for fs.promises (Anna Henningsen)
    #26581
* http:
  * makes response.writeHead return the response (Mark S. Everitt)
    #25974
* http2:
  * makes response.writeHead return the response (Mark S. Everitt)
    #25974
* n-api:
  * make func argument of napi\_create\_threadsafe\_function optional
    (legendecas)
    #27791
  * mark version 5 N-APIs as stable (Gabriel Schulhof)
    #29401
  * implement date object (Jarrod Connolly)
    #25917
* process:
  * add --unhandled-rejections flag (Ruben Bridgewater)
    #26599
* stream:
  * implement Readable.from async iterator utility (Guy Bedford)
    #27660
  * make Symbol.asyncIterator support stable (Matteo Collina)
    #26989

PR-URL: #29875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis

@jasnell jasnell

@cjihrig cjihrig

@mhdawson mhdawson

@addaleax addaleax

Assignees
No one assigned
Labels
C++ n-api
Projects
None yet
Milestone
No milestone
6 participants
@gabrielschulhof @nodejs-github-bot @bnoordhuis @jasnell @cjihrig @mhdawson
You can’t perform that action at this time.