Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: http2 anchor link formatting and reference #29362

Closed
wants to merge 1 commit into from

Conversation

@nschonni
Copy link
Contributor

commented Aug 29, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nschonni
doc: http2 anchor link formatting and reference 
Some links were flagged as empty links by Markdownlint MD042.
The HttpServerResponse anchor link was also not defined.
Loading status checks…
2dba702

@nodejs-github-bot nodejs-github-bot added doc http2 labels Aug 29, 2019

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Aug 29, 2019 •
edited

Thank you. Before this PR, these links were broken in the rendered pages, both GitHub (.md) and Node,js doctools (.html) variants (linked to the parent folder or just the document).
@cjihrig
cjihrig approved these changes Aug 29, 2019
View changes
@Trott
Trott approved these changes Aug 29, 2019
View changes
@jasnell
jasnell approved these changes Aug 29, 2019
View changes
@lpinca
lpinca approved these changes Aug 29, 2019
View changes
@trivikr
trivikr approved these changes Aug 30, 2019
View changes
@trivikr

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 30, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3870/

@trivikr trivikr added the author ready label Aug 30, 2019

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 31, 2019

Landed in ee8f02b

@Trott Trott closed this Aug 31, 2019

Trott added a commit that referenced this pull request Aug 31, 2019
@nschonni @Trott
doc: format http2 anchor link and reference 
Some links were flagged as empty links by Markdownlint MD042.
The HttpServerResponse anchor link was also not defined.

PR-URL: #29362
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Loading status checks…
ee8f02b

@nschonni nschonni deleted the nschonni:doc--http2-anchor-link-formatting-and-reference branch Aug 31, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
@nschonni @BridgeAR
doc: format http2 anchor link and reference 
Some links were flagged as empty links by Markdownlint MD042.
The HttpServerResponse anchor link was also not defined.

PR-URL: #29362
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
ebd2e7b
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
Merged
BridgeAR added a commit that referenced this pull request Sep 4, 2019
@nschonni @BridgeAR
doc: format http2 anchor link and reference 
Some links were flagged as empty links by Markdownlint MD042.
The HttpServerResponse anchor link was also not defined.

PR-URL: #29362
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
187d08b
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@nschonni @JeniaBR
doc: format http2 anchor link and reference 
Some links were flagged as empty links by Markdownlint MD042.
The HttpServerResponse anchor link was also not defined.

PR-URL: nodejs#29362
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
e6063b7
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@nschonni @JeniaBR
doc: format http2 anchor link and reference 
Some links were flagged as empty links by Markdownlint MD042.
The HttpServerResponse anchor link was also not defined.

PR-URL: nodejs#29362
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
a3b3993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@Trott Trott

@lpinca lpinca

@cjihrig cjihrig

@trivikr trivikr

Assignees
No one assigned
Labels
author ready doc http2
Projects
None yet
Milestone
No milestone
8 participants
@nschonni @vsemozhetbyt @trivikr @Trott @jasnell @lpinca @cjihrig @nodejs-github-bot
You can’t perform that action at this time.