Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove multiple consecutive blank lines #29352

Closed
wants to merge 1 commit into from

Conversation

@nschonni
Copy link
Contributor

commented Aug 28, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc label Aug 28, 2019

@mhdawson
mhdawson approved these changes Aug 28, 2019
View changes
Copy link
Member

left a comment

LGTM
@lpinca
lpinca reviewed Aug 28, 2019
View changes
doc/changelogs/CHANGELOG_V5.md Show resolved Hide resolved
@nschonni
nschonni reviewed Aug 28, 2019
View changes
Copy link
Contributor Author

left a comment

Another one to add back one line
doc/changelogs/CHANGELOG_IOJS.md Show resolved Hide resolved

@nschonni nschonni force-pushed the nschonni:doc--remove-multiple-consecutive-blank-lines branch from 95a14a2 to 4da634e Aug 28, 2019

@jasnell
jasnell approved these changes Aug 28, 2019
View changes
@nschonni
doc: remove multiple consecutive blank lines 
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.
Loading status checks…
954d153

@nschonni nschonni force-pushed the nschonni:doc--remove-multiple-consecutive-blank-lines branch from 4da634e to 954d153 Aug 29, 2019

@nschonni

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Aug 29, 2019

Rebased to fix merge conflict
@trivikr
trivikr approved these changes Aug 30, 2019
View changes
@trivikr

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 30, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3871/

@trivikr trivikr added the author ready label Aug 30, 2019

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 31, 2019

Landed in 9a46cfc

@Trott Trott closed this Aug 31, 2019

Trott added a commit that referenced this pull request Aug 31, 2019
@nschonni @Trott
doc: remove multiple consecutive blank lines 
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.

PR-URL: #29352
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Loading status checks…
9a46cfc

@nschonni nschonni deleted the nschonni:doc--remove-multiple-consecutive-blank-lines branch Aug 31, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
@nschonni @BridgeAR
doc: remove multiple consecutive blank lines 
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.

PR-URL: #29352
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
875c3d3
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
Merged
BridgeAR added a commit that referenced this pull request Sep 4, 2019
@nschonni @BridgeAR
doc: remove multiple consecutive blank lines 
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.

PR-URL: #29352
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
6734782
@XhmikosR

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Sep 4, 2019

Does remark-lint have this rule enabled @nschonni?
@nschonni

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 4, 2019

No, it doesn't look like it right now https://github.com/nodejs/remark-preset-lint-node/blob/master/index.js
@XhmikosR

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Sep 4, 2019

@nschonni nschonni referenced this pull request Sep 4, 2019
Merged
@nschonni

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 4, 2019

Good idea, I've submitted a PR
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@nschonni @JeniaBR
doc: remove multiple consecutive blank lines 
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.

PR-URL: nodejs#29352
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
12c808c
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
@nschonni @JeniaBR
doc: remove multiple consecutive blank lines 
These are rendered as single breaks.
Addresses Markdownlint MD012 rule.

PR-URL: nodejs#29352
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
ffc154d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca

@jasnell jasnell

@mhdawson mhdawson

@trivikr trivikr

Assignees
No one assigned
Labels
author ready doc
Projects
None yet
Milestone
No milestone
8 participants
@nschonni @trivikr @Trott @XhmikosR @jasnell @lpinca @mhdawson @nodejs-github-bot
You can’t perform that action at this time.